Bug 344491 - Strings from .action files are not translatable
Summary: Strings from .action files are not translatable
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 2.9.4
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-23 15:37 UTC by Alexander Potashev
Modified: 2016-05-24 09:04 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2015-02-23 15:37:59 UTC
This is probably a problem of the whole Calligra repository, not just Krita.

The action names from .action files are not extracted to the translation template, for example this one in krita/krita.action:
    <Action name="set_weighted_brush_smoothing" icon="" text="Brush Smoothing: Weighted" whatsThis="" toolTip="Brush Smoothing: Weighted" iconText="Brush Smoothing: Weighted" shortcut="" defaultShortcut="" isCheckable="false" statusTip=""/>

Because the string is not translated, I can open "Settings -> Configure Shortcuts..." in Krita and see the untranslated message "Brush Smoothing: Weighted" in the list of actions.

Reproducible: Always
Comment 1 Halla Rempt 2015-02-23 15:42:55 UTC
Hm... That's sort of weird... I'd have expected these strings to be translated, because all these strings also occur in the code. There must be something I misunderstand about the translation process then.
Comment 2 Alexander Potashev 2015-05-30 10:15:24 UTC
The string "F&amp;ull Screen Mode" in krita/krita.action is not translatable because it appears there with an accelerator, and without accelerator in calligra/main/KoMainWindow.cpp.
Comment 3 Halla Rempt 2015-05-31 10:54:49 UTC
Weird, though, Krita doesn't use KoMainWindow anymore.
Comment 4 Alexander Potashev 2015-06-04 11:35:18 UTC
Oh, sorry, it is translated now, don't know why it wasn't a few days ago. Must be some configuration problem in my system.

But actions like "Brush Smoothing: Weighted" are still not translated because this one has context string "@action" in the code and doesn't have context in krita.action.
Comment 5 Halla Rempt 2015-06-05 08:45:12 UTC
Hm... I wonder if adding the string krita.action makes it work, or if that breaks something else.
Comment 6 Halla Rempt 2016-05-24 09:04:00 UTC
Fixed with 25ecbafce8365e44ebc550d23e62e61aa01efe1b