Bug 344445 - [PATCH] Fixed the problem when filelight goes into mounted file systems
Summary: [PATCH] Fixed the problem when filelight goes into mounted file systems
Status: RESOLVED WORKSFORME
Alias: None
Product: filelight
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other FreeBSD
: NOR normal
Target Milestone: ---
Assignee: Martin Sandsmark
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2015-02-22 10:43 UTC by Yuri
Modified: 2018-10-29 02:23 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
patch (1.36 KB, patch)
2015-02-22 10:44 UTC, Yuri
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri 2015-02-22 10:43:39 UTC
The problem is that mountes systems were detected without the trailing slash, but compared with the trailing slash. So the were missed, and FS boundary was crossed.

See an attached patch.

filelight-4.14.2

Reproducible: Always
Comment 1 Yuri 2015-02-22 10:44:07 UTC
Created attachment 91212 [details]
patch
Comment 2 Stefan Majewsky 2015-04-27 18:30:19 UTC
Hi Yuri, I would recommend that you post this patch on https://git.reviewboard.kde.org which seems to be the preferred method for patch submission nowadays.
Comment 3 Yuri 2015-04-27 18:46:54 UTC
Never even heard of https://git.reviewboard.kde.org 

My regularkde login doesn't pass there, and there is even no "register" link there.
Just a hassle. Forget it.
Comment 4 Christoph Feck 2015-05-02 20:10:44 UTC
Yuri, https://identity.kde.org/ does not work for you? Or are you talking about a different "regular kde login"?
Comment 5 Yuri 2015-05-02 20:21:46 UTC
I talked about my kde login that I now use here in bugzilla.
It doesn't work in both review board and https://identity.kde.org/
Comment 6 Yuri 2015-05-02 20:24:53 UTC
But I am more interested in this patch being checked in actually.
Comment 7 Gregor Mi 2018-04-17 14:36:09 UTC
Hello Yuri,
thanks for sending us a patch. The procedure of having a patch reviewed - which is a prerequisite to have it checked in - nowadays takes place on Phabricator. Please have a look at this page https://community.kde.org/Infrastructure/Phabricator. It explains the process in detail.
Comment 8 Yuri 2018-04-17 18:42:03 UTC
(In reply to Gregor Mi from comment #7)
> Hello Yuri,
> thanks for sending us a patch. The procedure of having a patch reviewed -
> which is a prerequisite to have it checked in - nowadays takes place on
> Phabricator. Please have a look at this page
> https://community.kde.org/Infrastructure/Phabricator. It explains the
> process in detail.

I don't remember what is this about now, after 3+ years.
Comment 9 Andrew Crouthamel 2018-09-28 03:17:07 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 10 Andrew Crouthamel 2018-10-29 02:23:16 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!