Bug 344210 - Make it possible to choose the quality of transform preview, especially for tiny images
Summary: Make it possible to choose the quality of transform preview, especially for t...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-15 21:29 UTC by Bollebib
Modified: 2019-02-01 14:25 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bollebib 2015-02-15 21:29:43 UTC
So with warp in particular but also other transform tools there is an issue that the preview is unreliable for really small images (pixelart) 

it would be good to have a UI to choose this
Apparently it's not that hard to do so I can mark it as JJ.

granularity seems to be the settings that needs to be adjusted,according to DmitryK





21:53:55 - Bollebib: dmitryK_: I'm wondering
21:54:13 - Bollebib: I'm doing some things with  warp transform,
21:54:36 - Bollebib: when I move them around and when I apply it seems the result is vastly different sometimes
21:54:39 - Bollebib: is this normal?
21:55:10 - dmitryK_: Bollebib: yes, the preview is lowres
21:56:55 - Bollebib: dmitryK_: when i move some points that should absolutely be moving pixels it sometimes does nothing
21:57:36 - Bollebib: dmitryK_: I think there is a problem with the preview
21:58:39 - Bollebib: dmitryK_: or maybe it's just because I'm working at really low pixel sizes
21:59:42 - Bollebib: mmmh,in another image it seems to be working fine..
22:03:55 - dmitryK_: Bollebib: the preview works with 5px granilarity afair
22:09:52 - Bollebib: dmitryK_: I guess I never work this pixelated before,it seemed like an issue
22:10:13 - dmitryK_: Bollebib: preview is twice less precise than the result
22:10:51 - dmitryK_: Bollebib: you can add a report, but with title "Make it possible to choose the quality of transform preview, especially for tiny images"
Comment 1 Halla Rempt 2016-01-24 12:32:07 UTC
WISHGROUP: Larger Usability Fixes
Comment 2 Dmitry Kazakov 2018-12-25 14:06:19 UTC
Git commit ea51095a4be8ddbb10aac9908fe3597dbd361a92 by Dmitry Kazakov, on behalf of Kuntal Majumder.
Committed on 25/12/2018 at 14:05.
Pushed by dkazakov into branch 'master'.

Added a QSpinBox to adjust granularity while doing transforms

Summary:
The patch adds a QSpinBox to the transform tool options to adjust the granularity while doing transforms.

This patch fixes real transformation granularity only, preview
granularity will be solved in the following patches.

Reviewers: #krita, rempt, dkazakov
Reviewed By: #krita, dkazakov
Subscribers: #krita
Tags: #krita

Differential Revision: https://phabricator.kde.org/D17660

M  +9    -0    plugins/tools/tool_transform2/kis_tool_transform_config_widget.cpp
M  +2    -0    plugins/tools/tool_transform2/kis_tool_transform_config_widget.h
M  +3    -3    plugins/tools/tool_transform2/kis_transform_utils.cpp
M  +1    -0    plugins/tools/tool_transform2/tool_transform_args.cc
M  +9    -0    plugins/tools/tool_transform2/tool_transform_args.h
M  +63   -21   plugins/tools/tool_transform2/wdg_tool_transform.ui

https://commits.kde.org/krita/ea51095a4be8ddbb10aac9908fe3597dbd361a92
Comment 3 Bollebib 2019-01-08 12:27:43 UTC
i tried to find this option but could not find it in the 4.2 nightly
Comment 4 Kuntal Majumder 2019-01-21 10:33:43 UTC
Git commit cf276a7086f459cdf902c10ac883795f3d039b7a by Kuntal Majumder.
Committed on 21/01/2019 at 10:30.
Pushed by kuntalmajumder into branch 'master'.

tool/transform : Can manipulate granularity during cage transform

Summary:
The patch adds a QComboBox to the transform tool options to adjust the
granularity preview while doing cage transforms, it also changes the
QSpinBox to change the real granularity to a QComboBox.

Reviewers: #krita, rempt, dkazakov
Reviewed By: #krita, dkazakov
Subscribers: #krita
Tags: #krita

Differential Revision: https://phabricator.kde.org/D17807

M  +0    -2    libs/image/kis_cage_transform_worker.cpp
M  +1    -3    plugins/tools/tool_transform2/kis_cage_transform_strategy.cpp
M  +24   -3    plugins/tools/tool_transform2/kis_tool_transform_config_widget.cpp
M  +2    -1    plugins/tools/tool_transform2/kis_tool_transform_config_widget.h
M  +8    -1    plugins/tools/tool_transform2/tool_transform_args.cc
M  +11   -0    plugins/tools/tool_transform2/tool_transform_args.h
M  +51   -35   plugins/tools/tool_transform2/wdg_tool_transform.ui

https://commits.kde.org/krita/cf276a7086f459cdf902c10ac883795f3d039b7a
Comment 5 Kuntal Majumder 2019-02-01 14:17:18 UTC
Git commit 59b1004c1bf8513f9ab74f9472dd8f1caf0f7f3a by Kuntal Majumder.
Committed on 01/02/2019 at 14:11.
Pushed by kuntalmajumder into branch 'master'.

tool/transform: undo/redo works for granularity values in cage transform
Differential Revision: https://phabricator.kde.org/D18427

M  +3    -0    plugins/tools/tool_transform2/kis_tool_transform_config_widget.cpp
M  +17   -5    plugins/tools/tool_transform2/tool_transform_args.cc
M  +2    -1    plugins/tools/tool_transform2/tool_transform_args.h

https://commits.kde.org/krita/59b1004c1bf8513f9ab74f9472dd8f1caf0f7f3a
Comment 6 Kuntal Majumder 2019-02-01 14:17:18 UTC
Git commit c0fa53e3710580a4faa6285b63e98e2bb0fe72d2 by Kuntal Majumder.
Committed on 01/02/2019 at 14:15.
Pushed by kuntalmajumder into branch 'master'.

tool/transform: added a test for cage transform args
Differential Revision: https://phabricator.kde.org/D18427

M  +32   -0    plugins/tools/tool_transform2/tests/test_save_load_transform_args.cpp
M  +1    -0    plugins/tools/tool_transform2/tests/test_save_load_transform_args.h

https://commits.kde.org/krita/c0fa53e3710580a4faa6285b63e98e2bb0fe72d2