Bug 344208 - Silence/Activity notification should have button to activate window
Summary: Silence/Activity notification should have button to activate window
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: monitoring (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-15 20:58 UTC by Elias Probst
Modified: 2022-07-05 09:08 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/utilities/konsole/commit/8fb68993891996dfcb1dee0d3ddc97870b19d430
Version Fixed In:
mail: Usability+

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Probst 2015-02-15 20:58:07 UTC 
The notification emitted by Silence/Activity monitoring is missing any context from which window it was emitted.
It would be nice to have a "Show" or "Activate" button in the notification which activates the window from which the event was triggered.

Sometimes I monitor several windows/tabs at once in multiple activities and then have a hard time finding the window responsible for the notification.

Running:
- Qt 5.4.0
- KF5/Plasma 5/KDE Applications 5 from git master/frameworks (all components up-to-date)
Comment 1 Piotr Dobrogost 2016-01-14 10:11:44 UTC 
There's similar request for bell notifications in bug #305162.
Comment 2 Bug Janitor Service 2022-01-13 12:13:28 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/581
Comment 3 tcanabrava 2022-07-05 09:08:47 UTC 
Git commit 8fb68993891996dfcb1dee0d3ddc97870b19d430 by Tomaz  Canabrava, on behalf of Luis Javier Merino Morán.
Committed on 05/07/2022 at 09:04.
Pushed by tcanabrava into branch 'master'.

Focus session from notification

Adds a "Show session" button to notifications, which, when clicked, will
focus the originating session.

Original patch by Kasper Laudrup at bug 305162, then updated by Martin
T. H. Sandsmark.

Now updated and extended to silence/activity/process termination
notifications, adding support for focusing a TerminalDisplay inside a
hierarchy of ViewSplitters inside a TabbedViewContainer, and using
KWindowSystem::forceActiveWindow() instead of ::activateWindow().
Related: bug 305162

M  +6    -0    src/MainWindow.cpp
M  +3    -0    src/MainWindow.h
M  +1    -0    src/ViewManager.cpp
M  +2    -0    src/ViewManager.h
M  +14   -10   src/session/Session.cpp
M  +8    -5    src/session/SessionController.cpp
M  +9    -4    src/terminalDisplay/TerminalBell.cpp
M  +3    -1    src/terminalDisplay/TerminalBell.h
M  +5    -0    src/terminalDisplay/TerminalDisplay.cpp
M  +3    -0    src/terminalDisplay/TerminalDisplay.h
M  +14   -0    src/widgets/ViewContainer.cpp
M  +1    -0    src/widgets/ViewContainer.h

https://invent.kde.org/utilities/konsole/commit/8fb68993891996dfcb1dee0d3ddc97870b19d430