Bug 343775 - Disable non-english feeds by default
Summary: Disable non-english feeds by default
Status: RESOLVED FIXED
Alias: None
Product: Planet KDE
Classification: Websites
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Ranveer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-04 15:29 UTC by Jonathan Riddell
Modified: 2018-11-07 18:26 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Patch that fixes this. (1.08 KB, patch)
2015-02-13 14:52 UTC, Ranveer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Riddell 2015-02-04 15:29:19 UTC
Please disable non-English feeds by default, people are not internationally minded to read them


Reproducible: Always
Comment 1 Ranveer 2015-02-13 14:52:52 UTC
Created attachment 91051 [details]
Patch that fixes this.

From now on, if PlanetKDE is opened on a new browser, non-English feeds won't be visible by default. They'll have to be enabled via the configuration menu.
Comment 2 Jonathan Riddell 2015-02-16 12:17:52 UTC
Git commit ae4f0fcf07265d85cf6d198bbc46a4b19a045000 by Jonathan Riddell.
Committed on 16/02/2015 at 12:17.
Pushed by jriddell into branch 'master'.

hide non-english blogs by default

M  +6    -6    planetkde/planet_template

http://commits.kde.org/websites/planet-kde-org/ae4f0fcf07265d85cf6d198bbc46a4b19a045000
Comment 3 Jonathan Riddell 2015-02-16 12:25:41 UTC
I'm not convinced this has worked, launching chromium with a blank profile it still has Spanish blogs ticked in configure and it still displays Baltasar Ortega blogs
Comment 4 Jonathan Riddell 2015-02-16 12:46:41 UTC
12:45 < Riddell> ranveeraggarwal: interesting, now when I start chromium is does have the language classes unticked by default
12:45 < Riddell> ranveeraggarwal: and it doesn't show baltasar's blog
12:45 < Riddell> ranveeraggarwal: but when I tick the classes it still doesn't show baltasar's blog
Comment 5 Jonathan Riddell 2015-02-26 19:30:04 UTC
it doesn't show non-english by default but it doesn't save my settings when I choose to show some blogs.   Possibly this works when the blogs are currently in the website feed but it should work all the time.
Comment 6 Jonathan Riddell 2018-11-07 18:26:45 UTC
This seems to work now. It didn't disable feeds on first use of the website if the CDN decided to set a cookie first so I changed it to only look for cookies we set.