Bug 343753 - Oxygen-qt5 is much more spacious than Oxygen-qt4
Summary: Oxygen-qt5 is much more spacious than Oxygen-qt4
Status: REPORTED
Alias: None
Product: Oxygen
Classification: Plasma
Component: style (show other bugs)
Version: 5.2.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
: 346533 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-02-03 23:22 UTC by Albert Astals Cid
Modified: 2022-11-19 17:58 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
kscreen with default oxygen5 (72.85 KB, image/png)
2017-04-27 10:22 UTC, dev.dliw
Details
kscreen with compact oxygen5 (82.17 KB, image/png)
2017-04-27 10:23 UTC, dev.dliw
Details
Menu items take more space with oxygen5 than with breeze (135.21 KB, image/png)
2017-04-27 10:26 UTC, dev.dliw
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Astals Cid 2015-02-03 23:22:59 UTC
konsole bottom tab is about 40px with oxygen-Qt5 and about 25px with oxygen-qt4
konsole menu is about 29px with oxygen-qt5 and about 20px with oxygen-qt4
konsole "view menu" is about 320px with oxygen-qt5 and about 240px with oxygen-qt4

In understand breeze is supposed to be more spacious but what is the reason for oxygen-qt5 being so much more spacious than oxygen-qt4? Aren't they supposed to be drop-in replacements?
Comment 1 Hugo Pereira Da Costa 2015-02-09 12:44:34 UTC
The reason behind oxygen@qt5 is more spacious than (old) oxygen@qt4 is that it was a long request from several (and some of them vocals) users during kde4 times, to which we (Nuno and I) at that time at least, agreed, but could not implement in a 'consistent' manner because oxygen's code had become somewhat bloated over time.

While writing the breeze theme, the code ended up being much cleaner, and the cleaning could be backported to oxygen, which in turn, could allow us to add this long-standing spacing. 

However, as for breeze, some fine tuning might indeed still be necessary. I'll keep this bug report open and add it to future (hopefully soon) changes with that respect.
Comment 2 Albert Astals Cid 2015-02-09 18:22:25 UTC
But that doesn't make any sense, the interesting thing that oxygen provides is that you can use both the qt4 style and the qt5 style and it should be seamless, but as it stands now they're two different styles, if the qt5 world provides you with the opportunity of doing what you wanted, cool, you should call it oxygen2, but calling it oxygen is misleading in a way that people will expect it to be metric compatible, and then it isn't.
Comment 3 Hugo Pereira Da Costa 2015-02-09 18:25:52 UTC
Oxygen @ KF5 is also compilable against KDE4 (cmake -DUSE_KDE4) just like breeze.
It is the one that should be used for KDE4 applications running under KF5. I've sent an email some time ago about this to packagers).
Comment 4 Hugo Pereira Da Costa 2015-04-24 07:40:51 UTC
*** Bug 346533 has been marked as a duplicate of this bug. ***
Comment 5 matheus4551 2017-04-21 18:50:00 UTC
I find the Breeze-like spacing/padding to be annoying, also the tabs doesn't match the KDE 4 version. Aside these things i consider the Qt5 port perfect.
Comment 6 dev.dliw 2017-04-27 10:21:39 UTC
For me it breaks applications and is one of the reasons I still stick to KDE4.
Some elements (like menu items) even take more space with Oxygen5 than with Breeze.

See the attached images (kscreen is only one example of an unusable application)...
Comment 7 dev.dliw 2017-04-27 10:22:12 UTC
Created attachment 105219 [details]
kscreen with default oxygen5
Comment 8 dev.dliw 2017-04-27 10:23:22 UTC
Created attachment 105220 [details]
kscreen with compact oxygen5

No problem with smaller metrics.

Patch can be found here:
https://build.opensuse.org/package/view_file/home:dliw/oxygen5-small/oxygen-metrics.patch?expand=0
Comment 9 dev.dliw 2017-04-27 10:26:01 UTC
Created attachment 105221 [details]
Menu items take more space with oxygen5 than with breeze
Comment 10 matheus4551 2017-04-27 16:48:55 UTC
This looks better, will try in my system.
Comment 11 Justin Zobel 2022-11-04 03:10:13 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 12 Bug Janitor Service 2022-11-19 05:13:12 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 13 dev.dliw 2022-11-19 17:58:34 UTC
I'm still patching oxygen5 to get smaller metrics (see https://bugs.kde.org/show_bug.cgi?id=343753#c8). So at least for me, this issue is relevant.