Krita's Layer Preview thumbnail in Layers Docker does not update to reflect my recent my actions until I hover the cursor over the Layers Docker. By "Preview" I didn't mean the hover popup preview but the small thumbnail that always displayed in the Docker's left column. There are exceptions – Filling and Transformation seemed to trigger the re-generation of the thumbnail once the operation is finished. This problem as been there for a while, Boud reminded me about it in Bug 343685, so I decided to report it as well. Reproducible: Always Steps to Reproduce: 1. Create a new document; 2. Brush >> Fill_circle preset >> Enlarge brush size >> Pure Red (so it is more visible); 3. Draw something >> The Layers Docker's thumbnails do not update; 4. Move the cursor over the Layers docker >> The thumbnails get re-generated. Actual Results: Layer Preview thumbnails do not update until cursor hovers over the Layers Docker. Expected Results: The thumbnails automatically updates to refelct recent change. If real-time refreshing is too taxing, do it once per 5-10 seconds or 5-10 steps, at least.
Hm, the speed with which the thumbnail is painted when hovering over the layer box suggests that we do the thumbnail updating in a timeley fashion but that somehow the widget isn't redrawn.
This was already the case in 2.8, I see.
And 2.7
And 2.6. But interestingly, it's not just hovering over the layerbox that updates the previews, it's also when a dialog or message box pops up.
Created attachment 90941 [details] patch to enable immediate thumbnail updates This patch needs testing... It updates the thumbnail as you go. Here it doesn't seem to cause any performance regression, not even big images. I had another patch that would introduce a timed delay, but that made Krita deadlock all the time.
Thank you for the patch. It seems to be working fine. I will keep my build static for a while to test it out. The preview updates the previous change when I begin a new action. Is that correct?
It depends a bit, painting gets updated when you end the stroke, but handling vector shapes causes immediate updates.
boud, unfortunately it does give me a slight performance regression. The tiles don't update as nicely as they should. Either make it optional(we have an entry for layer-thumbnails already), or discard it.
Git commit 65cfc79e83061aa9863a47e8a2641e750ee2cea2 by Boudewijn Rempt. Committed on 06/02/2015 at 13:49. Pushed by rempt into branch 'calligra/2.9'. M +10 -3 krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp M +3 -1 krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.h M +5 -0 krita/ui/KisDocumentSectionView.cpp M +1 -0 krita/ui/KisDocumentSectionView.h http://commits.kde.org/calligra/65cfc79e83061aa9863a47e8a2641e750ee2cea2
Git commit 75e35fbcd90b33a2df5d2c9276dd20db798f94db by Boudewijn Rempt. Committed on 06/02/2015 at 13:49. Pushed by rempt into branch 'master'. M +10 -3 krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp M +3 -1 krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.h M +5 -0 krita/ui/KisDocumentSectionView.cpp M +1 -0 krita/ui/KisDocumentSectionView.h http://commits.kde.org/calligra/75e35fbcd90b33a2df5d2c9276dd20db798f94db