Bug 343467 - Calendar applet should display week number when in panel
Summary: Calendar applet should display week number when in panel
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Calendar (show other bugs)
Version: 5.1.95
Platform: Other Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Martin Klapetek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-28 16:09 UTC by Chris Warrick
Modified: 2016-06-15 12:58 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.7.0


Attachments
top - kde 4; bottom - kde 5 (4.11 KB, image/png)
2015-01-28 16:14 UTC, Chris Warrick
Details
top = KDE 4 and bottom = KDE 5 (54.55 KB, image/png)
2015-09-09 21:05 UTC, Cyril Chaboisseau
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Warrick 2015-01-28 16:09:41 UTC
KDE 4 displayed the current weekday on the calendar icon.  Plasma 5 does not.

Reproducible: Always
Comment 1 Martin Klapetek 2015-01-28 16:11:36 UTC
Thanks for the report.

Which calendar icon do you have in mind?
Comment 2 Chris Warrick 2015-01-28 16:14:47 UTC
Created attachment 90753 [details]
top - kde 4; bottom - kde 5
Comment 3 Chris Warrick 2015-01-28 16:15:38 UTC
The attachment shows the icon; it’s displayed on the panel (when a calendar is there).
Comment 4 Martin Klapetek 2015-01-29 18:46:59 UTC
Ah right. We never actually considered using the calendar applet like that, more like putting it on the desktop as the same calendar popup is with the clock applet.

But I guess it could be made more useful...
Comment 5 Christoph Feck 2015-02-02 23:53:42 UTC
*** Bug 343713 has been marked as a duplicate of this bug. ***
Comment 6 T Kleindienst 2015-05-16 14:08:41 UTC
I am affected by this, too. It would be nice if the calendar applet also shows the number of the week.
Comment 7 Cyril Chaboisseau 2015-09-09 21:05:05 UTC
Created attachment 94494 [details]
top = KDE 4 and bottom = KDE 5

I would go further than what the screenshot describes (namely that the calendar icon should display the week number) and support that the *whole calendar* browsing should display the week number for each row (this is very useful when setting up a meeting).

See latest screenshot of how the 2 versions of calendar are presented
(top for KDE4 and bottom for KDE5)
Comment 8 Martin Klapetek 2015-09-09 22:22:49 UTC
> the *whole calendar* browsing should display the week number for each row 

This is already done in Plasma 5.4.
Comment 9 Kai Uwe Broulik 2016-06-13 21:16:30 UTC
I had a look at this just now but given how horrible JS Date() is I have no idea how to make this work properly without 1.) adding a C++ plugin or 2.) making a horrible JS hack. Other than that my patch works, you can even choose between having the day of month or week of year shown.
Comment 10 Martin Klapetek 2016-06-14 03:52:57 UTC
The Calendar applet already should have the C++ backend no?
Maybe we could make the week number available on the top-level
item of the Calendar and then just reuse in the compact representation?
Comment 11 Kai Uwe Broulik 2016-06-15 12:58:51 UTC
Git commit 857c0680f5c801f98f182a209f3aef02255dda83 by Kai Uwe Broulik.
Committed on 15/06/2016 at 12:58.
Pushed by broulik into branch 'master'.

[Calendar Applet] Show day or week number in icon

Rather than showing the generic calendar icon the day number is shown there instead.
There is also an option to have it show the week number instead.

FIXED-IN: 5.7.0

Differential Revision: https://phabricator.kde.org/D1867

M  +1    -1    applets/CMakeLists.txt
A  +14   -0    applets/calendar/CMakeLists.txt
C  +21   -17   applets/calendar/calendarapplet.cpp [from: applets/calendar/contents/ui/configGeneral.qml - 063% similarity]
C  +18   -16   applets/calendar/calendarapplet.h [from: applets/calendar/contents/config/config.qml - 066% similarity]
R  +0    -0    applets/calendar/package/contents/config/config.qml [from: applets/calendar/contents/config/config.qml - 100% similarity]
R  +3    -0    applets/calendar/package/contents/config/main.xml [from: applets/calendar/contents/config/main.xml - 087% similarity]
R  +-    --    applets/calendar/package/contents/images/mini-calendar.svgz [from: applets/calendar/contents/images/mini-calendar.svgz - 100% similarity]
R  +0    -0    applets/calendar/package/contents/ui/configAgenda.qml [from: applets/calendar/contents/ui/configAgenda.qml - 100% similarity]
R  +31   -0    applets/calendar/package/contents/ui/configGeneral.qml [from: applets/calendar/contents/ui/configGeneral.qml - 052% similarity]
R  +42   -8    applets/calendar/package/contents/ui/main.qml [from: applets/calendar/contents/ui/main.qml - 063% similarity]
R  +0    -0    applets/calendar/package/metadata.desktop [from: applets/calendar/metadata.desktop - 100% similarity]

http://commits.kde.org/plasma-workspace/857c0680f5c801f98f182a209f3aef02255dda83