Bug 343349 - in vertical panel icons in systemtray are ridiculously huge
Summary: in vertical panel icons in systemtray are ridiculously huge
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Tray (show other bugs)
Version: master
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
: 344705 349047 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-01-26 22:43 UTC by Eugene Shalygin
Modified: 2016-08-17 11:50 UTC (History)
11 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
comparison (116.79 KB, image/png)
2015-01-26 22:44 UTC, Eugene Shalygin
Details
Vertical panel in KDE pre-Plasma (45.45 KB, image/jpeg)
2015-10-27 09:08 UTC, Rafael Linux User
Details
blurry 22px icons (12.38 KB, image/png)
2015-12-19 10:50 UTC, Philipp A.
Details
huge icons in systray (8.75 KB, image/png)
2016-08-04 15:27 UTC, Eugene Shalygin
Details
Updated to latest KDE and still not fixed this annoying but (27.31 KB, image/png)
2016-08-11 12:42 UTC, Rafael Linux User
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Shalygin 2015-01-26 22:43:40 UTC
In Plasma 5 vertical panel has many shortcomings, and the size of icons in the system tray is one of them. I have 128 DPI screen, if it does matter, and in vertical mode icons are ~1.75 times larger than in horizontal one (see attached screenshot). Moreover, icons look blurry. Also take a look at the font in Choqok (the green one with a number) icon. It seem like pixmaps were just upscaled.

Reproducible: Always

Steps to Reproduce:
1. Move standard panel to the left edge of the screen


Actual Results:  
Icons become larger and blurred

Expected Results:  
System tray icons keep their size
Comment 1 Eugene Shalygin 2015-01-26 22:44:19 UTC
Created attachment 90683 [details]
comparison
Comment 2 Marco Martin 2015-01-27 11:55:38 UTC
how many dpi? the maximum size for systray icons depends from screen dpi density
Comment 3 Eugene Shalygin 2015-01-27 12:26:05 UTC
See above. But my concerns are not only about absolute icons size in vertical mode. It seems to me that their pixmaps are created for smaller icons, and are resized afterwards.
Comment 4 Saygın Bakşi 2015-01-30 02:39:51 UTC
I can confirm this problem. (fedora 21, kde plasma 5.2) 

I thought it was a dpi issue at first, but after manually altering the xorg.conf file with 96x96 dpi setting (correct dpi), the problem have not solved. I have changed the desktop theme to air, oxygen but the result was the same. 

Note that, when you resize the panel to use only one column for tray icons, the icons can be smaller depending on the size of the panel, but the default size of the icons are very big (in comparison to KDE4 tray icons). However, this might be a design decision.
Comment 5 David Edmundson 2015-05-16 22:42:28 UTC
*** Bug 344705 has been marked as a duplicate of this bug. ***
Comment 6 markuss 2015-08-19 12:57:06 UTC
*** Bug 349047 has been marked as a duplicate of this bug. ***
Comment 7 Vladimir 2015-09-24 19:09:07 UTC
After some systemtray sources digging I've found out some clues I ask for clarification.
There are two things  icon size dependent of:

1. applets/systemtray/package/contents/ui/main.qml:    
property int baseSize: theme.mSize(theme.defaultFont).height

It means, icon's baseSize depends on defaultFont height. Thus, font changes leads to icons size changes.  

2. ./package/contents/ui/main.qml:    property int itemSize: LayoutManager.alignedSize(Math.min(baseSize * 2, preferredItemSize))

It means, Icon's size equals to doubled height of theme's default  font.  

What's the reason to bind icon size to font size? What's the reason behind the multiplier "2"?
Obvious solution is to use preferred size  from Desktop/Panel whatever icon theme settings, isn't it?
Comment 8 Rafael Linux User 2015-10-27 09:08:29 UTC
Created attachment 95158 [details]
Vertical panel in KDE pre-Plasma

This is how it worked in KDE 4. There was a "quick launch" widget that do not exist in Plasma, and the icon launcher had a proportional size.
Comment 9 Philipp A. 2015-12-19 10:50:45 UTC
Created attachment 96197 [details]
blurry 22px icons
Comment 10 Philipp A. 2015-12-19 10:55:14 UTC
i have this problem as well.

no idea of a recent sans-serif font change or system upgrade caused it, but my icons are now 22px instead of 16px like before.

not only are some of the icons blurred (volume and network), but with the padding this now means i need >50px wide vertical bar to fit two columns (as seen in the screenshot above)

it would be very useful to

1. add 22px versions for the missing icons
2. give an option to keep the icons small
Comment 11 Marco Martin 2016-03-09 11:52:37 UTC
Systemtray implementation is changed, this should be one of the problems fixed.
Comment 12 Eugene Shalygin 2016-08-04 15:26:50 UTC
It is the case again with the current git master branch.
Comment 13 Eugene Shalygin 2016-08-04 15:27:29 UTC
Created attachment 100450 [details]
huge icons in systray

Illustration
Comment 14 Eugene Shalygin 2016-08-10 14:56:42 UTC
Fixed again.
Comment 15 James Rodriguez 2016-08-11 09:20:51 UTC
Fixed where? master? Which commit?
Comment 16 Rafael Linux User 2016-08-11 12:42:34 UTC
Created attachment 100552 [details]
Updated to latest KDE and still not fixed this annoying but
Comment 17 Vladimir 2016-08-17 11:50:33 UTC
plasma 5.7.3
Huge icons in systemtray in verical panel.

After viewing in design/qmls, I notice that code completely changed this time. 
As of now icon size depends on config entry iconSize, and there is a choice from "small", "smallMedium", "medium"... 

However there is no relevant option in "System Tray Settings" dialog.
Thus, this is a slightly different bug this time -  No visual dropdown list to choose desired icon size in Settings Dialog