Bug 343273 - Improve the info panel for photos
Summary: Improve the info panel for photos
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kfilemetadata
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Pinak Ahuja
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-25 11:57 UTC by Martin Klapetek
Modified: 2019-06-23 18:06 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Klapetek 2015-01-25 11:57:37 UTC
Currently the info panel in Dolphin5 has the image data sorted alphabetically, but that's not really useful as it puts for example camera maker and camera model above the data that is actually useful/needed/wanted. Also the namings are...too verbose and exify, not really userphotographer-friendly.

For me as a photographer it's quite hard to orient in all that. So I'd suggest to sort them differently and rename and in this order (the things in parenthesis are how they are currently labeled):

-----
Resolution ("Width x Height"):
Aperture ("Photo F Number"):
Exposure time ("Photo Exposure Time"):
ISO ("Photo ISO Speed"):
EV ("Photo Exposure Bias"):
Focal length ("Photo Focal Length"):
Flash ("Photo Flash"):
-----
Camera Model ("Image Model"):
Photo Original Date/Time:

...and remove the rest (now I don't actually know if these are on by default but these shouldn't be: Photo Aperture Value, Image Make, Photo Metering Mode, Photo White Balance, they are useless).

There should also ideally be a separator line between the general image/file data (Type, Size, Modified, Tags, Rating, Comment), otherwise it's a wall of text and it's hard to quickly spot the actual interesting data.

Couple more notes

-Resolution should imo put width/height together, it's always read like that anyway (and saves one line). Additionally it could also show resolution in MPx, like "3564x2495 (8 MPx)"

-Exposure time/Photo Exposure Time displays time as 0.0015625 for example but that's useless, in photography the values are estabilished as "1/something" when lower than 0.3, so it should display eg. 1/8, 1/200, 1/4000. These are also values that all cameras use so they are more understandable than 0.0015625 (which is 1/640).

-Photo Exposure Bias is similar to the above, it shows 0.333333, but more common is 1/3 or at least 0.3

-Photo Flash currently shows "16" at all my pictures. I believe that the actual value is like an enum or something, 16 means "Flash did not fire". So this should convert the values to actual meanings, I certainly didn't fire 16 flashes :)

-Photo Metering Mode is quite useless on its own, should maybe be removed altogether, similar is Photo White Balance (they have no real meaning for human reading)

-Aperture and Exposure time can also be put together, like "Exposure: 1/640 at F2.8", but I can't really tell if that's better than having it separated or not. Just an idea.
Comment 1 Christoph Feck 2015-01-25 14:47:09 UTC
Dolphin displays the data the way it obtains them from specialized metadata libraries. If the labels and/or values are not suitable for the display, I strongly believe that should be fixed in those libraries, instead of worked around in any client that uses those libraries.
Comment 2 Martin Klapetek 2015-01-25 15:53:22 UTC
Right, in Dolphin5 the KFileMetadata is used for that sidebar and those names should be changed there (I can see they are being direct transliteration of the exiv keys). That's why I added Vishesh in CC. Though on a second thought maybe I should have filed a special report just for the renaming and the values format.

In fact, how much of the info sidebar is Dolphin and how much is KFileMetadata? I'm thinking maybe this whole change would go just into KFileMetadata?
Comment 3 Frank Reininghaus 2015-01-25 22:26:48 UTC
(In reply to Martin Klapetek from comment #2)
> In fact, how much of the info sidebar is Dolphin and how much is
> KFileMetadata?

The widget in the Information Panel ist the FileMetaDataWidget from Baloo. I'm not sure though how much of what you suggest needs to be done there, and how much in KFileMetaData.
Comment 4 Vishesh Handa 2015-01-26 13:50:49 UTC
Martin, do you think you could provide a patch?

* The translated names come from KFileMetaData. Have a look at propertyinfo.cpp
* The actual widget comes from baloo-widgets. This is because the data is indexed in Baloo (and cached for faster lookups) - This could be changed if someone wants to do it. It's just the way things currently are.
Comment 5 Martin Klapetek 2015-01-26 14:47:45 UTC
Alright, I can sure give it a try.
Comment 6 Alexander Stippich 2019-02-12 21:33:29 UTC
Git commit e2bd6629783e6a884a23924c99c2fe32b0c8559f by Alexander Stippich.
Committed on 12/02/2019 at 21:33.
Pushed by astippich into branch 'master'.

Format EXIF photo flash data

Summary:
Translate the number of the EXIF
photo data to a human readable
string.

Reviewers: ngraham

Reviewed By: ngraham

Subscribers: kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D18972

M  +4    -0    autotests/propertyinfotest.cpp
M  +40   -0    src/formatstrings.cpp
M  +2    -0    src/formatstrings_p.h
M  +1    -0    src/propertyinfo.cpp

https://commits.kde.org/kfilemetadata/e2bd6629783e6a884a23924c99c2fe32b0c8559f
Comment 7 Alexander Stippich 2019-05-30 11:46:56 UTC
Git commit 3983d80727b4bb3ab5692386991389f7ffcd7ffd by Alexander Stippich.
Committed on 30/05/2019 at 11:46.
Pushed by astippich into branch 'master'.

Cleanup default filters for baloo-widgets

Summary:
The property names do not match any names defined in KFileMetaData.
While the intention of the previous filters clearly was to hide most of the EXIF information,
users seem to use the provided information (see bug report), so show most of it.
Hide photo metering mode, photo sharpness and white balance, as they seem to be quite useless.

Reviewers: ngraham, bruns

Reviewed By: bruns

Subscribers: #baloo

Tags: #baloo

Differential Revision: https://phabricator.kde.org/D21413

M  +7    -22   src/metadatafilter.cpp

https://commits.kde.org/baloo-widgets/3983d80727b4bb3ab5692386991389f7ffcd7ffd
Comment 8 Alexander Stippich 2019-05-30 11:47:13 UTC
Git commit de67dcb8263c6e3d52782372b555c75f4500b167 by Alexander Stippich.
Committed on 30/05/2019 at 11:47.
Pushed by astippich into branch 'master'.

Show 3 significant figures when displaying doubles

Summary:
Show 3 significant digits for double values when
displaying them with e.g. baloo-widgets
Also fixes localization

Reviewers: ngraham, bruns

Reviewed By: bruns

Subscribers: kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D21499

M  +27   -21   autotests/propertyinfotest.cpp
M  +5    -0    src/formatstrings.cpp
M  +2    -0    src/formatstrings_p.h
M  +9    -0    src/propertyinfo.cpp

https://commits.kde.org/kfilemetadata/de67dcb8263c6e3d52782372b555c75f4500b167
Comment 9 Alexander Stippich 2019-06-05 19:33:53 UTC
Git commit bfef0997eb771fdff5a87cbef8cad2e1fe7bd2f5 by Alexander Stippich.
Committed on 05/06/2019 at 19:33.
Pushed by astippich into branch 'master'.

Hide more exif data

Summary:
Hide some additional information
retrieved from exif, which seems not to be
useful

Reviewers: ngraham, bruns

Reviewed By: ngraham, bruns

Subscribers: #baloo

Tags: #baloo

Differential Revision: https://phabricator.kde.org/D21520

M  +3    -0    src/metadatafilter.cpp

https://commits.kde.org/baloo-widgets/bfef0997eb771fdff5a87cbef8cad2e1fe7bd2f5
Comment 10 Alexander Stippich 2019-06-05 19:34:14 UTC
Git commit 553f967696103099c197a59a206e3ebcce443b5d by Alexander Stippich.
Committed on 05/06/2019 at 19:34.
Pushed by astippich into branch 'master'.

Format the aperture values as F numbers.

Summary: CCBUG: 343273

Reviewers: bruns, ngraham

Reviewed By: ngraham

Subscribers: kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D21532

M  +2    -0    autotests/propertyinfotest.cpp
M  +5    -0    src/formatstrings.cpp
M  +2    -0    src/formatstrings_p.h
M  +3    -2    src/propertyinfo.cpp

https://commits.kde.org/kfilemetadata/553f967696103099c197a59a206e3ebcce443b5d
Comment 11 Alexander Stippich 2019-06-10 20:44:59 UTC
Git commit 2dc250bc9239d9f30f55110f4b3b8329c202a5c3 by Alexander Stippich.
Committed on 10/06/2019 at 20:44.
Pushed by astippich into branch 'master'.

Format photo exposure time as rational when applicable

Summary:
If value is below 0.3, format the output as
rational which is commonly used in photography.
Value is computed from the double input value.

Reviewers: bruns, ngraham

Reviewed By: bruns

Subscribers: kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D21533

M  +3    -2    autotests/propertyinfotest.cpp
M  +13   -0    src/formatstrings.cpp
M  +2    -0    src/formatstrings_p.h
M  +1    -1    src/propertyinfo.cpp

https://commits.kde.org/kfilemetadata/2dc250bc9239d9f30f55110f4b3b8329c202a5c3
Comment 12 Alexander Stippich 2019-06-14 19:24:00 UTC
Git commit 131947acb0b2b065d5c23341785c97e52cbca292 by Alexander Stippich.
Committed on 14/06/2019 at 19:23.
Pushed by astippich into branch 'master'.

Rename ImageMake and ImageModel properties

Summary:
Provide a more generic and meaningful property
and display name for the previous ImageMake and
ImageModel properties.

Reviewers: ngraham, bruns

Reviewed By: ngraham

Subscribers: kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D21519

M  +2    -2    src/extractors/exiv2extractor.cpp
M  +22   -1    src/properties.h
M  +8    -8    src/propertyinfo.cpp

https://commits.kde.org/kfilemetadata/131947acb0b2b065d5c23341785c97e52cbca292
Comment 13 Alexander Stippich 2019-06-14 19:24:11 UTC
Git commit 135fc25b6feb6958f55645ad33ba1551bd16bd98 by Alexander Stippich.
Committed on 14/06/2019 at 19:24.
Pushed by astippich into branch 'master'.

Remove photo prefix from every exif property name

Summary:
Remove the 'photo' prefix from every exif property,
as this is pretty redundant

Reviewers: ngraham, bruns

Reviewed By: ngraham

Subscribers: kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D21772

M  +18   -18   src/propertyinfo.cpp

https://commits.kde.org/kfilemetadata/135fc25b6feb6958f55645ad33ba1551bd16bd98
Comment 14 Alexander Stippich 2019-06-21 17:28:46 UTC
Git commit 0a042beb5568a073612c2752b4c4b64b675e2a81 by Alexander Stippich.
Committed on 21/06/2019 at 17:28.
Pushed by astippich into branch 'master'.

Format photo exposure bias value

Summary:
Format the photo exposure bias value in EV units
and in steps of thirds when applicable

Reviewers: bruns, ngraham

Reviewed By: bruns

Subscribers: kde-frameworks-devel, #baloo

Tags: #frameworks, #baloo

Differential Revision: https://phabricator.kde.org/D21830

M  +8    -0    autotests/propertyinfotest.cpp
M  +33   -0    src/formatstrings.cpp
M  +2    -0    src/formatstrings_p.h
M  +1    -1    src/propertyinfo.cpp

https://commits.kde.org/kfilemetadata/0a042beb5568a073612c2752b4c4b64b675e2a81
Comment 15 Alexander Stippich 2019-06-23 18:06:13 UTC
Git commit b9fcf84f7fa3d9584b9d77dbc4641a21d0d7ac5c by Alexander Stippich.
Committed on 23/06/2019 at 18:05.
Pushed by astippich into branch 'master'.

Rework sorting of properties

Summary:
Rework sorting of properties in the file
information panel and tooltips.
Rename "audio" and "music" sorting key to "media" as
they are also used for videos and images.

Final piece for

Reviewers: ngraham, bruns

Reviewed By: ngraham

Subscribers: #baloo

Tags: #baloo

Differential Revision: https://phabricator.kde.org/D22024

M  +29   -15   src/filemetadataprovider.cpp

https://commits.kde.org/baloo-widgets/b9fcf84f7fa3d9584b9d77dbc4641a21d0d7ac5c