Hello, When I used it last time in 2013 softproofing was working like expected. Even out-of-gamut colors were shown. Yesterday I tried to use it again and had no sucess. Color management is installed and works as usually. But when I go into the editor and activate softproofing nothing happens. The picture is still unchanged. I tested it with pictures I know that there is a visible difference during softproofing. The test machine with Ubuntu 12.04 is unchanged since 2013, except for normal updates. Tried to update digikam 4.0 to 4.7, but there is no improvement. Digikam is self compiled, but that was also the situation in 2013. On top of this I tried it on my new notebook which is running Ubuntu 14.04 with digikam 4.1. Same behaviour. Color management works, but softproofing not. The softproof profiles are o.k., as they are working perfectly in geeqie, gimp or darktable. HTH Guenther
Which Lcms version you use with digiKam ? Look in Help/Components Info dialog for details. Can you share one image to process and color profile to use to try to reproduce the problem ? Gilles Caulier
I have looked into the code of digikam 3.5.0. The code for softproofing has in digikam 4.7.0 at the moment no function. Maik
MAik, No function ? Which code exist in 3.x which do not exist in 4.x ? Gilles
Gilles, I made the evening yesterday before a first hack. Masks color still does not work, is always black. editorcore.cpp:329 void EditorCore::updateColorManagement() { IccManager manager(d->image); if (d->doSoftProofing) { d->monitorICCtrans = manager.displaySoftProofingTransform(d->cmSettings.defaultProofProfile, d->displayingWidget); } else { d->monitorICCtrans = manager.displayTransform(d->displayingWidget); } } d->monitorICCtrans is set but never used. d->displayingWidget is never set -> value 0. The code to set color management is now in imagepreviewitem.cpp but no softproofing code. Maik
Ah, yes, i understand now. It's another part dropped due to canvas model/view port between 3.x to 4.x. Code can be ported as well into imagepreviewitem.cpp without to many difficulties i think. Gilles
Created attachment 90629 [details] softproofing.patch The weather today was bad here, snow slush. ;-) I put a patch ready for testing. Softproofing works in the editor and in the tool preview. Softproofing mask color is now correct viewed.
Created attachment 90630 [details] softproofing2.patch Const statement forget for a new function.
Git commit 198ce7028266a7da94708f544da729949d826360 by Gilles Caulier. Committed on 25/01/2015 at 11:11. Pushed by cgilles into branch 'master'. Apply patch from Maik Qualmann to restore Softproofing freature in Image Editor due to canvas model/view port initiate with 4.0.0 release while Google Summer of Code FIXED-IN: 4.7.0 M +2 -1 NEWS M +3 -3 libs/dklcms/digikam-lcms.cpp M +6 -31 utilities/imageeditor/core/editorcore.cpp M +1 -1 utilities/imageeditor/core/editorcore.h M +0 -2 utilities/imageeditor/core/editorcore_p.h M +1 -0 utilities/imageeditor/editor/editorwindow.cpp M +15 -4 utilities/imageeditor/plugin/imageiface.cpp M +0 -1 utilities/imageeditor/widgets/canvas.cpp M +14 -3 utilities/imageeditor/widgets/imagepreviewitem.cpp M +14 -3 utilities/imageeditor/widgets/imageregionitem.cpp http://commits.kde.org/digikam/198ce7028266a7da94708f544da729949d826360
Git commit 2c4f8691b5c1ab57c404cf718b6b64500ae94e3c by Gilles Caulier. Committed on 25/01/2015 at 11:34. Pushed by cgilles into branch 'frameworks'. backport commit #198ce7028266a7da94708f544da729949d826360 from git/master to frameworks branch M +3 -3 libs/dklcms/digikam-lcms.cpp M +7 -31 utilities/imageeditor/core/editorcore.cpp M +1 -1 utilities/imageeditor/core/editorcore.h M +0 -2 utilities/imageeditor/core/editorcore_p.h M +1 -0 utilities/imageeditor/editor/editorwindow.cpp M +15 -4 utilities/imageeditor/plugin/imageiface.cpp M +0 -1 utilities/imageeditor/widgets/canvas.cpp M +14 -3 utilities/imageeditor/widgets/imagepreviewitem.cpp M +14 -3 utilities/imageeditor/widgets/imageregionitem.cpp http://commits.kde.org/digikam/2c4f8691b5c1ab57c404cf718b6b64500ae94e3c
Guys, You are great! Just recompiled digikam and and I can confirm that soft proofing is working again. Thanks a lot! Best regards, Guentehr