Bug 343218 - Create selection when enabling Show Global Selection
Summary: Create selection when enabling Show Global Selection
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-23 17:43 UTC by Paul Geraskin
Modified: 2018-08-20 11:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Geraskin 2015-01-23 17:43:32 UTC
Hi.
SelectionMask Painting does not work when no selection in Krita 2.9. It's not possible to paint without selection. But in Gimp/PS it's possible to paint. All unselected area makes red.

Thanks.
Comment 1 Halla Rempt 2015-01-27 10:18:11 UTC
Right. The interaction needs a bit of thinking, though -- do we create the empty selection when pressing show global selection, or make the show-selection-as-mask button create a selection? I don't think we'll manage to implement this in time for 2.9 :-(.
Comment 2 Dmitry Kazakov 2018-08-17 16:11:21 UTC
Git commit 23be34a6bd97a01cc6615e06209018e3868ea3b6 by Dmitry Kazakov.
Committed on 17/08/2018 at 16:10.
Pushed by dkazakov into branch 'master'.

Make ShowGlobalSelectionMask option auto-create the mask

1) When the option is activated and there is no global mask yet,
   a new mask is created.

2) When the option is deactivated and the global selection mask
   is empty (nothing selected!), then the mask is automatically
   deleted

TODO: perhaps we don't want to save this option into KisConfig
      anymore, but somehow activate that depending on the presence
      on a global selection in the image?
CC:kimageshop@kde.org

M  +13   -0    libs/image/kis_layer_utils.cpp
M  +8    -0    libs/image/kis_layer_utils.h
M  +45   -10   plugins/dockers/defaultdockers/kis_layer_box.cpp

https://commits.kde.org/krita/23be34a6bd97a01cc6615e06209018e3868ea3b6
Comment 3 Dmitry Kazakov 2018-08-20 11:43:24 UTC
Git commit 5e2a52d78d1ea559443d1ed31a4660eda2705da6 by Dmitry Kazakov.
Committed on 20/08/2018 at 11:43.
Pushed by dkazakov into branch 'master'.

Do not create extra mask if the user has a deactivated selection mask already

M  +21   -0    plugins/dockers/defaultdockers/kis_layer_box.cpp

https://commits.kde.org/krita/5e2a52d78d1ea559443d1ed31a4660eda2705da6