Bug 343147 - Konversation doesn't cope well with Breeze in KF5
Summary: Konversation doesn't cope well with Breeze in KF5
Status: RESOLVED WAITINGFORINFO
Alias: None
Product: Breeze
Classification: Plasma
Component: QStyle (show other bugs)
Version: 5.1.95
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-22 09:14 UTC by Vit Pelcak
Modified: 2015-01-26 14:21 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screen of tabs (1.40 KB, image/png)
2015-01-22 09:15 UTC, Vit Pelcak
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vit Pelcak 2015-01-22 09:14:43 UTC
Hello.

When more tabs are opened in Konversation, only 3 dots display instead of channels/nicks.

That makes it quite difficult to use. See attachment.

Reproducible: Always
Comment 1 Vit Pelcak 2015-01-22 09:15:18 UTC
Created attachment 90579 [details]
screen of tabs
Comment 2 Eike Hein 2015-01-22 13:25:47 UTC
The tab bar is a standard Qt widget, and its appearance is controlled by Qt: Konversation has no involvement there. To fit more tabs I recommend switching them to the left side of the window in the config, or switching theme engines, or convincing the Breeze developers there is a design problem.
Comment 3 Vit Pelcak 2015-01-22 13:57:31 UTC
Well, in that case maybe it would be better to reassign to breeze developers.
Comment 4 Hugo Pereira Da Costa 2015-01-22 14:01:51 UTC
mmm
we agree that there will always be a number of tabs for which there is no room to display the text ? 
Breeze has a minimum tab bar size, so admitedly this might happen earlier than with other styles, but still. 

Two ways out: 
- to Vit: use "side" tabs (which will create a scrollab 
- to Eike: why isn't the tabbar scrollable ? I can imagine the tabs text not being truncated, and arrows to appear on the sides  ?

In any case, there is nothing on our side (breeze) we can do.
Comment 5 Eike Hein 2015-01-22 14:08:52 UTC
> - to Eike: why isn't the tabbar scrollable ? I can imagine the tabs text not being truncated, and arrows to appear on the sides  ?

This is actually style-dependent, or rather the style can set a default: http://doc-snapshot.qt-project.org/qt5-5.3/qtabbar.html#usesScrollButtons-prop
Comment 6 Hugo Pereira Da Costa 2015-01-22 14:25:57 UTC
mmm. ok. I'll change the default.
Still, doesn't it make sense to make it style *independent* and to true, in konversation ?
Comment 7 Eike Hein 2015-01-22 14:35:35 UTC
Well, I'd have to try what it does. You can see that the documentation is confusing and makes it sound like it's mutually exclusive. If you look at the screenshot, there's scroll buttons on the tab bar already. If that prop changes the label behavior it should be named differently.
Comment 8 Hugo Pereira Da Costa 2015-01-26 14:08:40 UTC
Comming back to this bug report
in fact it seems the issue does not come with the presence of the scrolling arrows, (which I missed on the screenshot), but rather with the elide mode.
In this case I think elision should be set to none, which would result in the tabs text not being truncated (and the arrows to appear earlier, while the tabs are still fully readable)

Now, the default elision mode in tabbars is set to "style dependent" which, in turn, should be ElideNone in breeze (and any other QCommonStyle)


@Vit: does the problem persist if you use a different widget style ? (plastique, or fusion, depending if you use KF5 or KDE4). If yes, that's definitly not a Breeze-specific bug.

@Eike: do you ovverride the Elision mode for Konvi's tabbar in the code ? and if yes, well, that might be the issue ...
Comment 9 Hugo Pereira Da Costa 2015-01-26 14:09:39 UTC
... At least, here, I cannot reproduce the issue with dolphin (oppening many tabs)
Comment 10 Eike Hein 2015-01-26 14:18:12 UTC
> @Eike: do you ovverride the Elision mode for Konvi's tabbar in the code ?

No.

I'm not really sure changing the elide mode is reasonable, though. It's a balance thing; there's a range of number of tabs in which eliding the labels is more useful than never eliding in terms of using the space efficiently. I think that once you have so many tabs that elided labels become not useful, you're better off switching to the vertical listview.
Comment 11 Hugo Pereira Da Costa 2015-01-26 14:21:17 UTC
... then I (In reply to Eike Hein from comment #10)
> > @Eike: do you ovverride the Elision mode for Konvi's tabbar in the code ?
> 
> No.
mmm then I have no clue where the elision mode comes from. (since it does not come from the style)

Lets wait for whether the same issue happens with other widget style.