Bug 342864 - Close button doesn't obey Fitts law
Summary: Close button doesn't obey Fitts law
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: window decoration (show other bugs)
Version: 5.1.95
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-15 08:10 UTC by Antonio Rojas
Modified: 2015-01-21 15:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot (19.70 KB, image/png)
2015-01-19 08:30 UTC, Antonio Rojas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2015-01-15 08:10:23 UTC
When using small buttons size in the Breeze windows decoration, a maximized window doesn't close when clicking on the top right screen corner. It works on the right border slightly below the top, so the problem seems to be in the top margin. 

Reproducible: Always
Comment 1 Marco Martin 2015-01-15 09:48:08 UTC
kdecoration2 or aurora?
Comment 2 Antonio Rojas 2015-01-15 09:57:33 UTC
kdecoration (using 5.2 beta)
Comment 3 Hugo Pereira Da Costa 2015-01-19 08:24:34 UTC
I cannot reproduce (with breeze)
What exactly is your button layout  ? (screenshot)
Comment 4 Hugo Pereira Da Costa 2015-01-19 08:26:00 UTC
and in fact there is another bug report complaining about missing margins, (because of top being removed), due to exactly the requirement of Fitts law.
See: http://wstaw.org/m/2015/01/19/plasma-desktopt10138.png
Comment 5 Antonio Rojas 2015-01-19 08:30:04 UTC
Created attachment 90506 [details]
Screenshot

I can only reproduce in my laptop, which has a high DPI and is using a 18pt font for the label text. In my other machine I'm using a 14pt size font and it works correctly
Comment 6 Hugo Pereira Da Costa 2015-01-19 08:32:17 UTC
ok. Makes sense. This is because the text area is larger than the button area, in your laptop case
and since the buttons are vertically centered, you get extra empty pixels around them (to match the font height)
I guess I should extend their hit area instead
Thanks for reporting, I'll work on it !
Comment 7 Hugo Pereira Da Costa 2015-01-19 09:05:10 UTC
Git commit 4dd75758dcb1b970c5e1c6638df0fa4f1aab542e by Hugo Pereira Da Costa.
Committed on 15/01/2015 at 10:07.
Pushed by hpereiradacosta into branch 'master'.

Moved buttons geometry handling to Breeze::decoration
Do not change size of titlebar when maximizing.
Expend buttons hit area to satisfy Fitts law in maximize mode
Related: bug 342824

M  +3    -12   kdecoration/breezebutton.cpp
M  +9    -0    kdecoration/breezebutton.h
M  +22   -15   kdecoration/breezedecoration.cpp
M  +8    -9    kdecoration/breezedecoration.h

http://commits.kde.org/breeze/4dd75758dcb1b970c5e1c6638df0fa4f1aab542e
Comment 8 Hugo Pereira Da Costa 2015-01-21 15:29:03 UTC
Git commit ab80e3880f9a6928038147b339faafcf91279302 by Hugo Pereira Da Costa.
Committed on 15/01/2015 at 10:07.
Pushed by hpereiradacosta into branch 'Plasma/5.2'.

Moved buttons geometry handling to Breeze::decoration
Do not change size of titlebar when maximizing.
Expend buttons hit area to satisfy Fitts law in maximize mode
Related: bug 342824

M  +3    -12   kdecoration/breezebutton.cpp
M  +9    -0    kdecoration/breezebutton.h
M  +22   -15   kdecoration/breezedecoration.cpp
M  +8    -9    kdecoration/breezedecoration.h

http://commits.kde.org/breeze/ab80e3880f9a6928038147b339faafcf91279302