Bug 342816 - kcmshell5 kwindecoration drag to reposition buttons is broken
Summary: kcmshell5 kwindecoration drag to reposition buttons is broken
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: decorations (show other bugs)
Version: 5.1.95
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-14 00:18 UTC by illumilore
Modified: 2019-02-11 17:25 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.16.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description illumilore 2015-01-14 00:18:29 UTC
When bringing up kcmshell5 kwindecoration, in the drag to reposition buttons area, clicking on any of the entries and dragging them is completely broken. They never move. Clicking default also never resets the buttons on the titlebar.

Reproducible: Always
Comment 1 Thomas Lübking 2015-01-15 00:55:59 UTC
Not reproducible.
What exact Qt version do you use?
Comment 2 illumilore 2015-01-15 06:01:31 UTC
i | libQt5Core5                      | package | 5.4.0-174.2                 | x86_64 | (System Packages)
Comment 3 Martin Flöser 2015-01-15 08:32:09 UTC
which kwin version are you using? Note that the kcm changed for 5.2. So if your problem is in 5.1 it's probably going to be a wontfix.
Comment 4 illumilore 2015-01-15 20:06:19 UTC
kwin5                     | package | 5.1.95-44.1   | x86_64 | (System Packages)
Comment 5 Thomas Lübking 2015-01-16 13:02:21 UTC
there've been several dnd related changes to qt5.4

for 5.4.1 (i don't know what the build number indicates towards commit history) it seems mandatory to reimplement mimeTypes or canDropMimeData in the model, but i don't know whether and how this affects qml
Comment 6 Luke-Jr 2016-09-30 10:16:39 UTC
I am experiencing this problem with Qt 5.6.1, KF 5.23.0, Plasma/KWin 5.6.5.

Icons simply don't move from the icon area when dragged. Removing buttons works somewhat, but klunky...
Comment 7 Tony 2016-09-30 13:49:23 UTC
Working fine on Neon. Plasma 5.8.90, Frameworks 5.27 and Qt 5.7, although i  must say that moving icons on the title bar is a bit "tricky".

As for the "Defaults" button, i can confirm is not working, it does nothing.
Comment 8 Nate Graham 2019-02-11 17:25:08 UTC
author	Valerio Pilo <vpilo@coldshock.net>	2019-02-07 16:32:05 +0100
committer	Valerio Pilo <vpilo@coldshock.net>	2019-02-10 13:01:04 +0100
commit	8350c0f2ce666e60ad468a0f2fdce6086d2210f2 (patch)
tree	c5eb4d45b0ff004111b32afeaca8cfd790ab09c9
parent	698b40dbbde327a6824c2c6495201a27b34bc4a2 (diff)
[kcmkwin/kwindecoration] Rewrite the KWin decorations settings as a ConfigModuleHEADmaster
Summary:
* Wrote new KCM based on KQuickAddons::ConfigModule.
* Remade QMLs for Buttons and Themes tabs.
* Updated bridge model code for new plugin lookup API (fixes warnings).
* Fixed decoration shadow changing messing with the previews sizes.
* Fixed button drag and drop issues (see D18104).
* Fixed default settings button behavior and detection of settings changes.
* Updated Get Hot New Stuff.
* Removed apply button in previewbridge.cpp: After applying changes, a theme's KCModule is invalidated.

BUG: 389431
BUG: 350122
BUG: 346222
BUG: 342816
BUG: 397595

{F6574963} | {F6574962} | {F6574961} | {F6574960}

Test Plan:
* Verified saving and loading for every setting
* Checked shadows of Breeze and Oxygen
* Tested all possible drag&drop operations on both sides of the fake titlebar
* Changed color schemes (with `kcmshell5 colors`) while showing the Themes tab to see if all previews update correctly their palettes
* Tested on a fresh Neon-developer account, via kcmshell and systemsettings

Reviewers: #vdg, abetts, ngraham, #kwin, davidedmundson

Reviewed By: #vdg, #kwin, davidedmundson

Subscribers: zzag, GB_2, ngraham, broulik, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D18458