Bug 342555 - [Save-as] the save-as dialog propose no default filename, no format, no path
Summary: [Save-as] the save-as dialog propose no default filename, no format, no path
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: 2.9 Beta
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 313051 342408 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-01-06 14:25 UTC by David REVOY
Modified: 2015-09-22 10:52 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
[^ screenshot : example of an empty save-as dialog on Gnome ] (598.51 KB, image/png)
2015-01-06 14:25 UTC, David REVOY
Details
[^ screenshot : Save-As dialog on Mint 17 Cinnamon ] (47.60 KB, image/png)
2015-01-08 20:28 UTC, David REVOY
Details
Just a visual summarization of the save/export dialogs above (287.04 KB, image/png)
2015-02-15 22:36 UTC, mvowada
Details
Save/Export dialogs, desirable changes by users. (288.82 KB, image/png)
2015-06-15 01:17 UTC, mvowada
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2015-01-06 14:25:42 UTC
Created attachment 90260 [details]
[^ screenshot : example of an empty save-as dialog on Gnome ]

How to reproduce :
================
1. Open an existing artwork file
 2. Press Ctrl+Shift+S or File>Save As

Result :
======
As in the attached screenshot ; the dialog appear empty ( file name ) , no format pre-selected , and with a path in the home directory. On other apps ; when requesting a 'Save As' action , the software fill the name in the filename entry box, setup the same format, and the same path as the original . It helps to save a derivation of the current artwork ( changing the naming, or the file format or just the path ).

Note :
=====
Here again , I'm on Fedora 21 / Gnome 3.14 ; and this "Save As" box is themed as my system. So, I presume it's a bug KDE user don't have with a native Save/Save As dialog.
Comment 1 mvowada 2015-01-06 15:00:27 UTC
I agree with you. Also when saving a new document, a default filename, in my opinion (Bug 342408).
Comment 2 Halla Rempt 2015-01-07 15:20:05 UTC
The path used is actually remembered, the default is the pictures location. The default file format is now .kra. I am not sure taking the default filename from the image title is such a good idea, since that tends to be always Unnamed -- better to let the user enter a new filename, I think.
Comment 3 David REVOY 2015-01-08 14:39:52 UTC
@Boud: Ok to let the user enter a new filename. ( If the user is in the right-directory, a single click on the file can append the name on the field. So it's also fast this way to make a derivative filename...  ) 

Still a issue here : on a fresh compile from today, I have 'save-as' opening only '/home/deevad'.  ( Cinnamon desktop,mint 17.1 )
Comment 4 mvowada 2015-01-08 17:45:49 UTC
"I am not sure taking the default filename from the image title is such a good idea, since that tends to be always Unnamed"

I think a blank field could be a bit disorienting for new users, while a suggested filename, seems more a friendly step, at least in my mind. The points in my mind would be: 
- speed up the process of inserting a descriptive name, 
- when many unsaved new documents are open 
- maybe, even if they wouldn't deserve to be saved, it could be that we need them right after, 
- and we want to proceed with a fast pace
Comment 5 mvowada 2015-01-08 17:53:45 UTC
"Still a issue here : on a fresh compile from today, I have 'save-as' opening only '/home/deevad'. ( Cinnamon desktop,mint 17.1 )"

Sorry to hear that... same path as original here on Ubuntu 14.04 Unity.
Comment 6 David REVOY 2015-01-08 20:28:41 UTC
Created attachment 90289 [details]
[^ screenshot : Save-As dialog on Mint 17 Cinnamon ]

Just for the info, I made a screenshot of my Save-as dialog. It looks to be managed by Qt/KDE ( name field on the bottom, different bookmarks ).
Comment 7 David REVOY 2015-01-09 10:18:32 UTC
New morning build, now the Save-As dialog setup the right path. Thanks !
Comment 8 Tyson Tan 2015-02-13 07:36:56 UTC
To add to the problem, on Gnome Fallback 3.8, these dialogues:

* Save
* Save As
* Export

They have no default filename suggested when pop up. They are all blank. Other than the filename-to-save, the existing files in the current directory are not listed as well. I will have to select certain file type to list them, otherwise I see nothing. 

This has bugged me for a long time, and many other users, too. I got many feedbacks from fellow Krita users saying that "Krita won't save for me", and they were probably from Windows. I decided to add my comment here because I got another complain today. -_-b

It really confuses me that even when Saving a new document, Krita won't suggest something like "unnamed.kra". 

My suggestion is:

* Save dialogue should suggest "unnanmed.kra" on the last used location.
* Save as dialogue should suggest the name of current document, on the same location.
* Export dialogue remembers the filename, extension and location of what used last time.
* All these dialogue, if not going to have a default suggestion of filename, at least make them display all files instead of nothing by default.
Comment 9 Halla Rempt 2015-02-13 11:38:28 UTC
Hm, I'm not sure... But I'll take a look!
Comment 10 David REVOY 2015-02-13 11:43:10 UTC
+1 with your observation Tyson. I confirm it. 
And thank you Boud for having a look at this. 

I also want to add here a behavior I noticed only recently, but certainly a bug relative to 'save-as path' existing since longer :
1. Open a *.kra file from the file browser ( 'Open with Krita' ). 
2. Do a modification
3. Menu > File > Save As
Result : Save As dialog propose the path on the disk of the file saved *before* , not the actual path.  It's really happening with the  'Open with Krita' ( Nemo/Nautilus file manager here ). It's annoying when working on two different project with similar folder structures (eg. I did many mistakes while working on the gfx of my recent website davidrevoy and peppercarrot folders. ).
Comment 11 mvowada 2015-02-14 03:14:01 UTC
I've summarized all the ideas for the various dialogs in the diagram below.
Look at "[X]" for the modifications to current settings.

--------------------------------------------------------------------------
SAVE (new file)
--------------------------------------------------------------------------
Title bar: | [X] "Save New Document"
Look path: | [―] last saved file path
File name: | [X] "Unnamed"
File type: | [―] "*.kra"

--------------------------------------------------------------------------
SAVE AS (existing)
--------------------------------------------------------------------------
Title bar: | [X] "Save Document As"
Look path: | [X] present file path
File name: | [X] present file name
File type: | [―] "*.kra"

--------------------------------------------------------------------------
SAVE AS (new file)
--------------------------------------------------------------------------
Title bar: | [X] "Save New Document As"
Look path: | [―] last saved file path
File name: | [X] "Unnamed"
File type: | [―] "*.kra"

--------------------------------------------------------------------------
EXPORT (existing)
--------------------------------------------------------------------------
Title bar: | [X] "Export Document As"
Look path: | [X] last exported file path
File name: | [X] last exported file name
File type: | [X] last exported file extension

--------------------------------------------------------------------------
EXPORT (new file)
--------------------------------------------------------------------------
Title bar: | [X] "Export New Document As"
Look path: | [X] last exported file path
File name: | [X] last exported file name
File type: | [X] last exported file extension

--------------------------------------------------------------------------
EXPORT AS PDF (existing)
--------------------------------------------------------------------------
Title bar: | [X] "Export Document As PDF"
Look path: | [X] present file path
File name: | [X] present file name
File type: | [X] "*.pdf"

--------------------------------------------------------------------------
EXPORT AS PDF (new file)
--------------------------------------------------------------------------
Title bar: | [X] "Export New Document As PDF"
Look path: | [―] last saved file path
File name: | [X] "Unnamed"
File type: | [X] "*.pdf"
Comment 12 mvowada 2015-02-14 03:23:47 UTC
*** Bug 342408 has been marked as a duplicate of this bug. ***
Comment 13 Tyson Tan 2015-02-14 05:04:50 UTC
(In reply to mvowada from comment #11)
Thank you for the summerization, mvowada!

A little to add:

For the setting of "SAVE AS (existing)", default the file type as "present file type" might be helpful. My point is some people use .ora (or other file type) as their main working document format instead of .kra, for the purpose to work with GIMP. If those people were doing save as, they probably want to use the present document type.
Comment 14 Halla Rempt 2015-02-14 10:53:34 UTC
*** Bug 313051 has been marked as a duplicate of this bug. ***
Comment 15 mvowada 2015-02-15 22:36:55 UTC
Created attachment 91099 [details]
Just a visual summarization of the save/export dialogs above
Comment 16 Tyson Tan 2015-02-16 05:16:33 UTC
(In reply to mvowada from comment #15)
> Created attachment 91099 [details]
> Just a visual summarization of the save/export dialogs above

Very clear, mvowada. I saw no problem there. Thank you!
Comment 17 sghpunk 2015-02-17 17:47:03 UTC
In the "Export" dialog of existing file. I want to see not last_exported name, but present filename.
Comment 18 Loren Dias 2015-03-30 21:43:22 UTC
This bug is present in Krita 2.9.1 on Arch Gnome.

This is a usability issue as most file strings are 30 - 40 characters so retyping when access to a keyboard is limited is not an option.

Figuring out which file is the correct .kra and clicking with the tablet pen is prone to human error and could lead to the destruction of important artwork so I don't consider that a workaround.

Please Fix, Thank You
Comment 19 mvowada 2015-06-13 12:20:46 UTC
Hello everyone.

Currently there are four different dialogs to save a document.
They come in handy depending on the case. Roughly:

- "Save" = (self-explanatory)
- "Save As..." = save with a different name/format
- "Export..." = save without leaving the document
- "Export as PDF..." = (self- explanatory)

Already exist some scattered debates elsewhere on bugzilla on what should be the file name, or the format, or again the directory location proposed when saving.

Problem is in my opinion, that the comments seem to concern each time only one of the four aspects listed above, part of a broader picture. So I'm wondering:

Can we agree on bringing our suggestions over a wider new proposal request on Bugzilla, from now on? What are your thoughts about it?

Thank you
Comment 20 Tyson Tan 2015-06-14 12:04:42 UTC
Hi mvowada,
I don't know what exactly you were talking about in comment 19, but I would love to see comment 13 being realized. Please do whatever you consider necessary to make it happen. Thank you.
Comment 21 David REVOY 2015-06-14 17:22:42 UTC
+1 with Tyson about comment 13.
Comment 22 mvowada 2015-06-15 01:17:21 UTC
Created attachment 93179 [details]
Save/Export dialogs, desirable changes by users.

Thank you for your feedbacks. I wish I were a developer!
Anyway here is a table with the most part of the desirable changes of the 4 dialogs by users, summarized and revised to version 2.9.5.

Comment #17: Could be Save As?
Comment 23 David REVOY 2015-06-15 02:46:36 UTC
@mvowada : Good graphic in attachment of comment 22 you made . Thanks for the work.
Comment 24 guruguru.sp 2015-06-20 11:33:40 UTC
Krita 2.9.5.1 Windows:
Opening existing file then save as: 
folder - same as the location of the existing file (works as expected)

Opening a new file then save as: 
folder - C:\Program Files\Krita (x64)\bin (This does not look right... expectation: My Picture folder?)
Comment 25 Halla Rempt 2015-08-25 14:38:43 UTC
Git commit 4d3aa4addad4c6252e91a468ac61a8df39a303c1 by Boudewijn Rempt.
Committed on 25/08/2015 at 14:38.
Pushed by rempt into branch 'calligra/2.9'.

File dialog: Set the full filename as default directory
Related: bug 344760

A bit of api confusion. Where the documentation talks about
default "default directory", it means "default filename including
path".

M  +3    -8    libs/widgets/KoFileDialog.cpp

http://commits.kde.org/calligra/4d3aa4addad4c6252e91a468ac61a8df39a303c1
Comment 26 mvowada 2015-08-26 07:55:59 UTC
(In reply to Boudewijn Rempt from comment #25)
> Git commit 4d3aa4addad4c6252e91a468ac61a8df39a303c1 by Boudewijn Rempt.
> Committed on 25/08/2015 at 14:38.
> Pushed by rempt into branch 'calligra/2.9'.
> 
> File dialog: Set the full filename as default directory
> Related: bug 344760
> 
> A bit of api confusion. Where the documentation talks about
> default "default directory", it means "default filename including
> path".
> 
> M  +3    -8    libs/widgets/KoFileDialog.cpp
> 
> http://commits.kde.org/calligra/4d3aa4addad4c6252e91a468ac61a8df39a303c1

Thank you, thank you very much!!!
Comment 27 Tyson Tan 2015-09-02 08:37:39 UTC
Thank you for fixing this, Boud! :D
Comment 28 Loren Dias 2015-09-22 07:39:50 UTC
Thank you so much @boud  ! I would hear about this bug at least every few days from my girl as she probably has been doing 25 hours a week in krita for the last 6 months.

I just noticed that after the last upgrade I haven't heard about that issue :)
Comment 29 Halla Rempt 2015-09-22 10:52:37 UTC
And in the end, it was so simple, and I was banging my head against the table so badly :-)