Bug 342537 - X in close button not centered correctly
Summary: X in close button not centered correctly
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-05 22:18 UTC by enoopt.adams
Modified: 2015-01-13 15:07 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Picture of the problem (6.86 KB, image/png)
2015-01-05 22:20 UTC, enoopt.adams 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description enoopt.adams 2015-01-05 22:18:23 UTC 
The red x in the close button for notifications isn't properly centered in the circle of the button.

Reproducible: Always
Comment 1 enoopt.adams 2015-01-05 22:20:33 UTC 
Created attachment 90247 [details]
Picture of the problem
Comment 2 Andrew Lake 2015-01-05 22:38:11 UTC 
Seems legit.
Comment 3 Martin Klapetek 2015-01-06 18:44:31 UTC 
That's probably a bug in the plasma components, the button in the notification applet (plasma-workspace/applets/notifications/package/contents/ui/NotificationItem.qml line 165) is pretty standard:

        PlasmaComponents.ToolButton {
            id: closeButton
            width: units.iconSizes.smallMedium
            height: width
            flat: compact
            iconSource: "window-close"
        }

Reassigning to components.
Comment 4 Marco Martin 2015-01-13 14:59:47 UTC 
Git commit d96a8505d9772aee5258738ec3c484a0d70673cc by Marco Martin.
Committed on 13/01/2015 at 14:59.
Pushed by mart into branch 'master'.

a check more on centering

Change-Id: Ib22fcc6fe727c8b2b5ddc2473663c1e56b1dad09

M  +1    -0    src/declarativeimports/plasmastyle/ToolButtonStyle.qml

http://commits.kde.org/plasma-framework/d96a8505d9772aee5258738ec3c484a0d70673cc
Comment 5 Marco Martin 2015-01-13 15:07:04 UTC 
reported to be fixed after above commit