Bug 342448 - Compile issues in origin/master Jan/2015
Summary: Compile issues in origin/master Jan/2015
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Portability-Compilation (show other bugs)
Version: 4.6.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-03 17:03 UTC by bogdan
Modified: 2017-08-19 20:59 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.7.0
Sentry Crash Report:


Attachments
Build log attached (61.17 KB, text/x-log)
2015-01-03 21:56 UTC, bogdan
Details
This log contains the error print. (59.85 KB, text/x-log)
2015-01-04 16:30 UTC, bogdan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description bogdan 2015-01-03 17:03:08 UTC
I have again issues compiling showfoto.  Is this a know problem is this related to my setup? I could not figure it out

This is what I get: 
[ 91%] Building CXX object showfoto/CMakeFiles/showfoto.dir/setup/setuptooltip.o
/software/software/Graphics/Photo/digikam/showfoto/setup/setuptooltip.cpp:51:7: error: ‘SetupToolTip’ has not been declared
 class SetupToolTip::Private
       ^
/software/software/Graphics/Photo/digikam/showfoto/setup/setuptooltip.cpp:52:1: error: expected unqualified-id before ‘{’ token
 {
 ^
/software/software/Graphics/Photo/digikam/showfoto/setup/setuptooltip.cpp:262:1: error: expected ‘}’ at end of input
 }  // namespace ShowFoto
 

When I use ccmake I get this warning. Could it be related to the compile problem?
If yes how to fix it. Thanks.

showfoto/CMakeFiles/showfoto.dir/build.make:192: recipe for target 'showfoto/CMakeFiles/showfoto.dir/setup/setuptooltip.o' failed
make[2]: *** [showfoto/CMakeFiles/showfoto.dir/setup/setuptooltip.o] Error 1
CMakeFiles/Makefile2:1339: recipe for target 'showfoto/CMakeFiles/showfoto.dir/all' failed
make[1]: *** [showfoto/CMakeFiles/showfoto.dir/all] Error 2
Makefile:117: recipe for target 'all' failed
make: *** [all] Error 2


CMake Warning (dev) in app/CMakeLists.txt:
   Policy CMP0022 is not set: INTERFACE_LINK_LIBRARIES defines the link
   interface.  Run "cmake --help-policy CMP0022" for policy details.  Use the
   cmake_policy command to set the policy and suppress this warning.

   Target "digikamdatabase" has an INTERFACE_LINK_LIBRARIES property which
   differs from its LINK_INTERFACE_LIBRARIES properties.

   INTERFACE_LINK_LIBRARIES:


Reproducible: Always


Actual Results:  
does not compile

Expected Results:  
Should compile
Comment 1 caulier.gilles 2015-01-03 21:40:36 UTC
Not reproducible here.

There is nothing special broken in source code

Can you clean up compilation trace and recompile again and report whole compilation trace here.

Gilles Caulier
Comment 2 bogdan 2015-01-03 21:56:16 UTC
Created attachment 90209 [details]
Build log attached

1) remove CMakeCache.txt
2) cmake ..
3) make clean
4) make -j2 | tee build.log

build.log attached
Comment 3 bogdan 2015-01-04 16:29:03 UTC
Comment on attachment 90209 [details]
Build log attached

it appears that the error was not included so I will attache another one from:

make -j2  2>&1 | tee build.log
Comment 4 bogdan 2015-01-04 16:30:05 UTC
Created attachment 90220 [details]
This log contains the error print.
Comment 5 caulier.gilles 2015-01-15 13:51:52 UTC
Git commit 2b54e82ab1f6c2f1d7987ef2ca7017638f051d07 by Gilles Caulier.
Committed on 15/01/2015 at 13:50.
Pushed by cgilles into branch 'master'.

fix compilation rules to shwofoto setup to prevent conflict with digiKam setup
FIXED-IN: 4.7.0

M  +1    -19   CMakeLists.txt
M  +2    -1    NEWS
M  +29   -21   showfoto/CMakeLists.txt
M  +2    -2    showfoto/main/showfoto.cpp
R  +5    -5    showfoto/setup/showfotosetup.cpp [from: showfoto/setup/setup.cpp - 098% similarity]
R  +1    -1    showfoto/setup/showfotosetup.h [from: showfoto/setup/setup.h - 096% similarity]
R  +2    -2    showfoto/setup/showfotosetupmetadata.cpp [from: showfoto/setup/setupmetadata.cpp - 098% similarity]
R  +1    -1    showfoto/setup/showfotosetupmetadata.h [from: showfoto/setup/setupmetadata.h - 095% similarity]
R  +2    -2    showfoto/setup/showfotosetupmisc.cpp [from: showfoto/setup/setupmisc.cpp - 098% similarity]
R  +1    -1    showfoto/setup/showfotosetupmisc.h [from: showfoto/setup/setupmisc.h - 095% similarity]
R  +2    -2    showfoto/setup/showfotosetuptooltip.cpp [from: showfoto/setup/setuptooltip.cpp - 099% similarity]
R  +1    -1    showfoto/setup/showfotosetuptooltip.h [from: showfoto/setup/setuptooltip.h - 095% similarity]

http://commits.kde.org/digikam/2b54e82ab1f6c2f1d7987ef2ca7017638f051d07
Comment 6 caulier.gilles 2015-01-15 14:55:24 UTC
Git commit f178c3d3a1ad1c8b8eae6f6e00069fb10a98b714 by Gilles Caulier.
Committed on 15/01/2015 at 14:54.
Pushed by cgilles into branch 'frameworks'.

backport commit #2b54e82ab1f6c2f1d7987ef2ca7017638f051d07 from git/master to frameworks branch

M  +0    -18   CMakeLists.txt
M  +28   -20   showfoto/CMakeLists.txt
M  +2    -2    showfoto/main/showfoto.cpp
R  +4    -4    showfoto/setup/showfotosetup.cpp [from: showfoto/setup/setup.cpp - 098% similarity]
R  +0    -0    showfoto/setup/showfotosetup.h [from: showfoto/setup/setup.h - 100% similarity]
R  +1    -1    showfoto/setup/showfotosetupmetadata.cpp [from: showfoto/setup/setupmetadata.cpp - 099% similarity]
R  +0    -0    showfoto/setup/showfotosetupmetadata.h [from: showfoto/setup/setupmetadata.h - 100% similarity]
R  +1    -1    showfoto/setup/showfotosetupmisc.cpp [from: showfoto/setup/setupmisc.cpp - 099% similarity]
R  +0    -0    showfoto/setup/showfotosetupmisc.h [from: showfoto/setup/setupmisc.h - 100% similarity]
R  +1    -1    showfoto/setup/showfotosetuptooltip.cpp [from: showfoto/setup/setuptooltip.cpp - 099% similarity]
R  +0    -0    showfoto/setup/showfotosetuptooltip.h [from: showfoto/setup/setuptooltip.h - 100% similarity]

http://commits.kde.org/digikam/f178c3d3a1ad1c8b8eae6f6e00069fb10a98b714
Comment 7 bogdan 2015-01-15 16:17:23 UTC
I confirm. Now it builds fine. Good work!