Bug 342092 - Space (%20) appended to the end of search strings passed to populate function of service scripts
Summary: Space (%20) appended to the end of search strings passed to populate function...
Status: RESOLVED WORKSFORME
Alias: None
Product: amarok
Classification: Applications
Component: Tools/Script Manager (show other bugs)
Version: 2.8-git
Platform: Other Other
: NOR normal
Target Milestone: 2.9
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-21 21:14 UTC by Be
Modified: 2022-11-16 05:16 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Be 2014-12-21 21:14:19 UTC
The string typed into the search bar is passed to service scripts as the third argument of the populate function. This string has '%20' appended to the end of it, which could interfere with a script's processing of the string. An easy workaround is for the script to use filter.slice(0,-3), but Amarok should pass the string to the script verbatim in the first place.

Reproducible: Always

Steps to Reproduce:
1. Type string in search bar for a scripted service.
2. Make scripted service display this string, for example by putting Amarok.debug(filter); in the populate function.

Actual Results:  
String has '%20' at the end.

Expected Results:  
String is passed to the script verbatim.
Comment 1 Be 2014-12-22 09:02:10 UTC
To be clear, the issue here is not that there is %20 instead of a space. The issue is that there is a space at the end even though it isn't typed into the search bar.
Comment 2 Justin Zobel 2022-10-17 00:40:44 UTC
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "CONFIRMED" when replying. Thank you!
Comment 3 Be 2022-10-17 17:13:54 UTC
Uh, Amarok is a dead project at this point. I'm surprised the bugs haven't all been closed already.
Comment 4 Bug Janitor Service 2022-11-01 05:05:10 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Bug Janitor Service 2022-11-16 05:16:37 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!