Bug 342008 - valgrind.h needs type cast for _zzq_default to compile with clang/llvm in 64-bit mode
Summary: valgrind.h needs type cast for _zzq_default to compile with clang/llvm in 64-...
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: 3.10.0
Platform: Android Linux
: NOR normal
Target Milestone: ---
Assignee: Julian Seward
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-18 18:58 UTC by chh
Modified: 2015-09-06 13:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description chh 2014-12-18 18:58:43 UTC
valgrind.h got a compiler warning/error from clang/llvm integrated assembler.
A potential fix for Android is in:
  https://android-review.googlesource.com/#/c/119291/1

which added a missing type cast for
      : "r" (_zzq_default), "r" (&_zzq_args[0]) 
to 
     : "r" ((unsigned long int)_zzq_default), "r" (&_zzq_args[0]) 

For the latest valgrind.h, type o _zzq_default is changed to unsigned long long int.

Could someone confirm this change and make it in valgrind?
Thanks.
Comment 1 Julian Seward 2015-09-06 13:11:00 UTC
Committed, r15633.  Thanks for the patch.