On a layer, multiple 'local selections' can be created but the all refer to the same (last) selection area. It would seem that they should refer to the selection that was active when the the 'local selection' was created Reproducible: Always Steps to Reproduce: 1.Create a normal layer 2. Make a selection using a selection tool 3.Create a 'local selection' nested layer 4. Make another selection using the selection tool 5. Create another 'local selection' on the same normal layer 6. On the layer list, make the original selection the active one 7. It now refers to the last selection made. Original selection is gone. Expected Results: Ex: What should happen is if two selections are made, one and then it's inverse and two 'local selections' are created, one of each, and they are both 'on', the whole layer should be part of the selection. Disabling one would just disable that selection. Or, don't allow multiple 'local selections' on the same layer.
There can be multiple selection on a layer, but only one can be active. In the layer box there is is a small circle icons that can be clicked to switch the active selection.
I know there is supposed to be but they cannot be different selections as far as I can see - this is the bug. Read carefully what I put in the bug report and try what I described there. -----Original Message----- From: bugzilla_noreply@kde.org [mailto:bugzilla_noreply@kde.org] On Behalf Of Sven Langkamp Sent: Wednesday, December 17, 2014 1:44 PM To: josephb275@gmail.com Subject: [krita] [Bug 341973] Multiple 'local selections' are allowed but not possible. https://bugs.kde.org/show_bug.cgi?id=341973 Sven Langkamp <sven.langkamp@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sven.langkamp@gmail.com --- Comment #1 from Sven Langkamp <sven.langkamp@gmail.com> --- There can be multiple selection on a layer, but only one can be active. In the layer box there is is a small circle icons that can be clicked to switch the active selection. -- You are receiving this mail because: You reported the bug.
They can be different. I should note that "active" in the case doesn't mean selected in the layer box, but the small icon has to be selected.
Created attachment 90022 [details] Screenshot that show the buttons to toggle between selections.
Didn't we only add that after 2.8? Joe is still using the latest stable, 2.8.3 on Windows.
Correct. When I use the small icon of a circle on the selection layer, I can only get one selection. Every time I make a second selection on a layer the last selection I made replaces all the previous selections. The graphics rendered in the layer look like everything is working as advertised (I see the same thing you have in your attachment) but going back to the original selection and expecting it to be what I had originally set it to, I find that it has been replaced by the last selection I made. In other words, I now have two local selection layers, both referring to the same (last) selection made. -----Original Message----- From: bugzilla_noreply@kde.org [mailto:bugzilla_noreply@kde.org] On Behalf Of Sven Langkamp Sent: Wednesday, December 17, 2014 2:35 PM To: josephb275@gmail.com Subject: [krita] [Bug 341973] Multiple 'local selections' are allowed but not possible. https://bugs.kde.org/show_bug.cgi?id=341973 --- Comment #3 from Sven Langkamp <sven.langkamp@gmail.com> --- They can be different. I should note that "active" in the case doesn't mean selected in the layer box, but the small icon has to be selected. -- You are receiving this mail because: You reported the bug.
I think I figured it out. When I make the first selection and make it a local selection, the default is that it remains selected after creation - the small circle on the layer has an outline. Then, I use the selection tool to create a second selection, this then replaces my original selection because that was still active (by default - little circle has an outline). I then create a second 'local selection'. I then have two layers having the same selection. When I manually deselect the first local selection layer (little circle click) and then use the selection tool to define another selection and make it a layer, it works as it should. So, maybe a fix would be to create the local selection layer but not have it selected by default after creation? Or make the row select (when the entire row of the local selection layer is highlighted) the only time when the already defined selection area can be edited. In other words just selecting the small circle should not allow the selection area to be redefined (only on), rather the selection layer row needs to be selected in order to change the definition of the selection. On another note, the menu item: Select -> Deselect is not wired to local selection layer. The two operations are trying to control the same property but the menu does not deselect in the layer (remove outline from circle) as one would think it would. Deselect on the menu should be a global deselect. Using the latest Dec 14 release. -----Original Message----- From: bugzilla_noreply@kde.org [mailto:bugzilla_noreply@kde.org] On Behalf Of Sven Langkamp Sent: Wednesday, December 17, 2014 2:35 PM To: josephb275@gmail.com Subject: [krita] [Bug 341973] Multiple 'local selections' are allowed but not possible. https://bugs.kde.org/show_bug.cgi?id=341973 --- Comment #3 from Sven Langkamp <sven.langkamp@gmail.com> --- They can be different. I should note that "active" in the case doesn't mean selected in the layer box, but the small icon has to be selected. -- You are receiving this mail because: You reported the bug.
I guess the best solution here would be to fix two bugs: 1) Deselect should deselect local selection as well 2) If we create a local selection and it uses global selection as a source for copying, then the global selection should be deselected after the operation
WISHGROUP: Small Usability Fixes
Git commit 40a489ee0b099124059e23b4f0462eb6b9135f8b by Dmitry Kazakov. Committed on 22/08/2018 at 15:08. Pushed by dkazakov into branch 'master'. Previously Deselect and Reselect actions could be used only for global selection. Now, if there is a local selection active, they will activate/deactivate the selection mask. CC:kimageshop@kde.org M +2 -0 libs/image/CMakeLists.txt A +65 -0 libs/image/commands/KisDeselectActiveSelectionCommand.cpp [License: GPL (v2+)] C +17 -6 libs/image/commands/KisDeselectActiveSelectionCommand.h [from: libs/image/commands/kis_selection_commands.h - 056% similarity] A +83 -0 libs/image/commands/KisReselectActiveSelectionCommand.cpp [License: GPL (v2+)] C +17 -6 libs/image/commands/KisReselectActiveSelectionCommand.h [from: libs/image/commands/kis_selection_commands.h - 059% similarity] M +1 -1 libs/image/commands/kis_deselect_global_selection_command.h M +1 -1 libs/image/commands/kis_reselect_global_selection_command.h M +2 -0 libs/image/commands/kis_selection_commands.h M +1 -0 libs/image/kis_selection.h M +2 -2 libs/ui/actions/kis_selection_action_factories.cpp https://commits.kde.org/krita/40a489ee0b099124059e23b4f0462eb6b9135f8b
Git commit bc8416ffe05d822efe07ed2778b259a9ed96a43d by Dmitry Kazakov. Committed on 22/08/2018 at 15:08. Pushed by dkazakov into branch 'master'. Deactivate global selection when creating a local selection from it M +18 -2 libs/ui/kis_mask_manager.cc https://commits.kde.org/krita/bc8416ffe05d822efe07ed2778b259a9ed96a43d