Bug 341913 - "Close Session" behaving as "Close Terminal" when session is split into several terminals.
Summary: "Close Session" behaving as "Close Terminal" when session is split into sever...
Status: REPORTED
Alias: None
Product: yakuake
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-15 13:31 UTC by silentz0r
Modified: 2020-09-10 04:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description silentz0r 2014-12-15 13:31:12 UTC
When in split mode (having more than 1 terminal in the current session), right click -> close session performs the equivalent of closing the current split terminal, while the other split remains opened. If I understand correctly, close session should close the entire session i.e. all terminals in that session.

Possible solutions: Renaming current "Close Session" to "Close Terminal".
Comment 1 Eike Hein 2014-12-15 13:36:39 UTC
This is not fixable because that context menu is provided by the Konsole KPart component which Yakuake embeds. The naming "Close Session" there is accidental and unrelated to Yakuake's idea of sessions. (You'll notice the "Close Session" on Yakuake's own tab context menu works correctly, as will the keyboard shortcut named like that.)
Comment 2 silentz0r 2014-12-15 13:41:46 UTC
I see. I'm on Arch, Konsole 2.14.2 and yakuake 2.9.9, and the behaviour is different.

Performing CTRL+D (or close session) on yakuake closes the current terminal, leaving the session open, while on Konsole it closes the entire session (and is actually named "close tab"), so it doesn't seem like the exact same context.
Comment 3 Eike Hein 2014-12-15 13:49:53 UTC
That's not the relevant shortcut. Ctrl+D is a bash shortcut that terminates the shell, which is the process running in the terminal emulator (the KPart) which then decides to destroy itself, causing Yakuake to close the split. Yakuake's own "Close Session" shortcut is Ctrl+Shift+W by default (the same as "Close Tab" in Konsole); see the "Configure Shortcuts" dialog in the main menu.
Comment 4 silentz0r 2014-12-15 13:51:18 UTC
I see. Do you reckon I should report this as a Konsole bug then? It's nothing major, but ideally it should be renamed and both functions should be present.
Comment 5 Eike Hein 2014-12-15 13:56:40 UTC
Yeah, probably.

From Konsole's POV the bug is this: In the KPart, the context menu action should just be called "Close" instead of talking about "Session".

From Yakuake's POV, it would be nice if the context menu was modifyable or at least extensible.
Comment 6 lava 2020-09-10 04:05:51 UTC
This issue is still present after 6 years. Konsole's `Close tab` works correctly and doesn't quit the program. Yakuake quites although there are other opened tabs.