Bug 341714 - 5.4.0: generate macros ignore fact that KF5_DATA_INSTALL_DIR can be absolute
Summary: 5.4.0: generate macros ignore fact that KF5_DATA_INSTALL_DIR can be absolute
Status: REPORTED
Alias: None
Product: buildsystem
Classification: Developer tools
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Alex Merry
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-09 20:39 UTC by Arkadiusz Miskiewicz
Modified: 2021-03-09 05:27 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arkadiusz Miskiewicz 2014-12-09 20:39:54 UTC
Building some kf5 apps fails like this:
make[2]: *** No rule to make target '/usr/usr/share/kf5/kdoctools/customization/kde-include-man.xsl', needed by 'po/nl/docs/desktoptojson/desktoptojson.8'.  Stop.

Note double /usr/usr.

That's because it uses KDOCTOOLS_CUSTOMIZATION_DIR  macro which is defined:
/usr/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake:set(KDOCTOOLS_CUSTOMIZATION_DIR "${KDOCTOOLS_DATA_INSTALL_DIR}/kdoctools/customization")

now KDOCTOOLS_DATA_INSTALL_DIR is defined as:
/usr/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake:set(KDOCTOOLS_DATA_INSTALL_DIR "${PACKAGE_PREFIX_DIR}//usr/share/kf5")

which in .in file looks like this:
./KF5DocToolsConfig.cmake.in:set(KDOCTOOLS_DATA_INSTALL_DIR "${PACKAGE_PREFIX_DIR}/@KF5_DATA_INSTALL_DIR@")

Note it already had absolute path specified in KF5_DATA_INSTALL_DIR. Yet it insist on adding another PACKAGE_PREFIX_DIR prefix. This is not correct if using absolute dirs at cmake time (and not relative).


Reproducible: Always
Comment 1 Luigi Toscano 2014-12-10 00:48:25 UTC
I've seen this pattern also in other files, for example:
kauth/KF5AuthConfig.cmake.in:set(KAUTH_STUB_FILES_DIR "${PACKAGE_PREFIX_DIR}/@KF5_DATA_INSTALL_DIR@/kauth/")
kded/KDEDConfig.cmake.in:set(KDED_DBUS_INTERFACE "${PACKAGE_PREFIX_DIR}/@DBUS_INTERFACES_INSTALL_DIR@/org.kde.kded5.xml")
ki18n/KF5I18nConfig.cmake.in:set(KI18N_MODULE_DIR "${PACKAGE_PREFIX_DIR}/@CMAKECONFIG_INSTALL_DIR@")
etc, so this is not just or at least bigger than just KDocTools. Redirecting to buildsystem (of course please push back if it is not correct).
Comment 2 Arkadiusz Miskiewicz 2014-12-10 07:01:19 UTC
kjs, too
Comment 3 Justin Zobel 2021-03-09 05:27:05 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.