Trying to set a crypto key in either the identities config, or through attaching a public key, the OK button does nothing. I can see my key, and can click on it, but I can't actually select it. It never seems to spawn gpg, or anything for that matter. Kleopatra seems to be working on its own for the most part. When I click on a key, I get these messages: log_kleo_ui: Kleo::ProgressDialog::slotDone() log_kleo_ui: Kleo::KeyListView::slotUpdateTimeout(): processing 1 items en block log_kleo_ui: KeySelectionDialog::slotSelectionChanged() log_kleo_ui: KeySelectionDialog::slotCheckSelection() log_kleo_ui: KeySelectionDialog::slotCheckSelection() log_kleo_ui: Kleo::ProgressBar::startStopBusyTimer() cur = -1 ; tot = 100 ; real = -1 log_kleo_ui: (new value) switch to reset "/home/dan/.gnupg" "/home/dan/.gnupg" log_kleo_ui: Kleo::ProgressDialog::slotDone() log_kleo_ui: KeySelectionDialog::slotSelectionChanged() log_kleo_ui: KeySelectionDialog::slotCheckSelection() Though when I click the 'OK' button, there is no log of anything happening. Reproducible: Always Steps to Reproduce: 1. Open identities editor, change to the Cryptography tab 2. Press the change button for PGP and view the list 3. Select a key and press 'OK' Actual Results: Absolutely nothing happens with no logs or errors Expected Results: A key is selected and used for signing/encryption
In void Kleo::KeySelectionDialog::slotOk(), it seems to be returning back to the widget if the key selection is not empty and the keys are valid, as referenced by this line: if (!mSelectedKeys.empty() && checkKeyUsage(mSelectedKeys, mKeyUsage)). Should it not accept() if that is true? I'm testing it now, but it seems the return/accept() conditions are reversed to me.
Created attachment 89899 [details] Possible fix for selection window I appear to have been right, at least from my testing I am now able to select and use keys properly. I don't really know what the timer is there for so I didn't touch that, but I think this should work.
Do you have same bug in 4.14 ? Code was not changed so patch is not correct. So bug is in other code.
Sorry, I have never run 4.14 so I can't say for sure. I had a hard time tracing that part of code so the handling of that issue might be elsewhere. I changed that part because it seemed like control was never passing back on the OK press
Do you know that kf5 kdepim will release in 18 months ? But I can't change this code without know if it's this bug occurs in stable version. Otherwise we will change this code and after fix real bug and it will still broken. So first step, look at if we can reproduce in 4.14 Secondary create an unit test for this feature 3: test on kf5 4: fix kf5 code. Regards.
Thank you for reporting this bug in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "CONFIRMED" when replying. Thank you!
Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone!
This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone!