Bug 341643 - "1 match found." needs a placeholder
Summary: "1 match found." needs a placeholder
Status: RESOLVED NOT A BUG
Alias: None
Product: frameworks-ktextwidgets
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Laurent Montel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-07 21:30 UTC by fios
Modified: 2018-12-20 07:23 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description fios 2014-12-07 21:30:12 UTC 
While translating this string:

ktextwidgets.pot

#: findreplace/kfind.cpp:624 findreplace/kfind.cpp:643
#, kde-format
msgid "1 match found."
msgid_plural "%1 matches found."
msgstr[0] ""
msgstr[1] ""

I found that msgid lacks a placeholder. Will numbers still be fetched correctly for other languages? E.g. in my language, msgstr[0] "" is used for both 1 and 11. I think we need  "%1 match found." here.

Reproducible: Always

Steps to Reproduce:
Not tested yet, I'm just translating.

Actual Results:  
"1 matches found."
"1 matches found."

Expected Results:  
"1 matches found."
"11 matches found."
Comment 1 Yuri Chornoivan 2018-12-20 07:23:23 UTC 
Sorry for the late reply.

Yes. This works for plurals (tested for Ukrainian). It is enough to translate the singular form as "%1 match found" (with the placeholder).