Bug 341589 - Cannot assign tag to a split
Summary: Cannot assign tag to a split
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: 4.7.1
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-12-05 19:08 UTC by Alejandro
Modified: 2019-03-24 18:12 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.8.4,5.0.4


Attachments
attachment-5600-0.html (2.78 KB, text/html)
2019-01-28 22:37 UTC, Brendan
Details
test file for ledger view (27.83 KB, text/xml)
2019-02-08 15:23 UTC, Ralf Habacker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro 2014-12-05 19:08:18 UTC
It can be done when the movement is between accounts. However, it cannot be done when the movement is to/from a category.

Reproducible: Always

Steps to Reproduce:
1. Create a transaction of $50, with two splits:

a) Expenses:Car = $25
b) Expenses:Clothes = $25

How do I assign tag Christmas 2014 to split b)? A workaround consists on making b) a transfer to a temporal cash account, and then moving those $25 to Expenses:Clothes, setting the tag.
Comment 1 mau 2019-01-27 16:12:03 UTC
Any news on this feature? I'd appreciate it as well :-)
Comment 2 Thomas Baumgart 2019-01-27 17:36:48 UTC
Work is underway. If you compile yourself, want to be a bit adventurous and set the ENABLE_UNFINISHEDFEATURES build variable to ON, then you can check out a new ledger view and a new transaction editor which among other new features allows setting the tag per split. It is not finished and not ready for production use yet. You can find this on the master branch of the development.
Comment 3 Brendan 2019-01-28 22:37:57 UTC
Created attachment 117709 [details]
attachment-5600-0.html

Thomas,

How do you turn a feature like this on? I assume it's done as part of the
cmake command but what is the correct syntax?

How do you confirm that the feature is active in your new build?

Thanks,

----
Brendan Coupe


On Sun, Jan 27, 2019 at 10:37 AM Thomas Baumgart <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=341589
>
> Thomas Baumgart <tbaumgart@kde.org> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>            Severity|minor                       |wishlist
>
> --- Comment #2 from Thomas Baumgart <tbaumgart@kde.org> ---
> Work is underway. If you compile yourself, want to be a bit adventurous
> and set
> the ENABLE_UNFINISHEDFEATURES build variable to ON, then you can check out
> a
> new ledger view and a new transaction editor which among other new features
> allows setting the tag per split. It is not finished and not ready for
> production use yet. You can find this on the master branch of the
> development.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
Comment 4 Thomas Baumgart 2019-01-29 07:20:15 UTC
I use ccmake to turn it on. Or you run cmake -DENABLE_UNFINISHEDFEATURES=ON. You will have a new view at the bottom of the left pane called 'New ledger'.
Comment 5 Ralf Habacker 2019-02-06 15:54:33 UTC
Git commit c712d81154ef2fd5bb136bc4521ba3d046b74ba6 by Ralf Habacker.
Committed on 06/02/2019 at 14:18.
Pushed by habacker into branch '4.8'.

Add support for assigning tags in transaction splits editor

M  +57   -11   kmymoney/dialogs/kmymoneysplittable.cpp
M  +19   -0    kmymoney/dialogs/kmymoneysplittable.h
M  +1    -0    kmymoney/dialogs/ksplittransactiondlg.cpp
M  +8    -1    kmymoney/dialogs/ksplittransactiondlg.h
M  +1    -0    kmymoney/dialogs/transactioneditor.cpp
M  +0    -1    kmymoney/reports/listtable.cpp
M  +6    -0    kmymoney/reports/querytable.cpp

https://commits.kde.org/kmymoney/c712d81154ef2fd5bb136bc4521ba3d046b74ba6
Comment 6 Brendan 2019-02-07 00:59:13 UTC
Thomas,

I modified my build scripts to make it easy to add the
-DENABLE_UNFINISHEDFEATURES=ON option and/or ask about running ccmake
before running make. Thanks for the tip.

I was able to get my latest 5.0 build to include the New Ledger option
but when I click on it KMM crashes.

The output on the command line is:

$ kmymoney
WebConnect: Running in server mode
Couldn't start kuiserver from org.kde.kuiserver.service:
QDBusError("org.freedesktop.DBus.Error.ServiceUnknown", "The name
org.kde.kuiserver was not provided by any .service files")
Segmentation fault (core dumped)

Anything I can do to help troubleshoot this problem?


----
Brendan Coupe
KMyMoney Build Scripts - Easily Build KMyMoney From Source Code
https://drive.google.com/drive/folders/1sfo2HgzaCCSb3d7pjl3To50yoQT5BaXM


----
Brendan Coupe



On Wed, Feb 6, 2019 at 8:54 AM Ralf Habacker <bugzilla_noreply@kde.org> wrote:
>
> https://bugs.kde.org/show_bug.cgi?id=341589
>
> --- Comment #5 from Ralf Habacker <ralf.habacker@freenet.de> ---
> Git commit c712d81154ef2fd5bb136bc4521ba3d046b74ba6 by Ralf Habacker.
> Committed on 06/02/2019 at 14:18.
> Pushed by habacker into branch '4.8'.
>
> Add support for assigning tags in transaction splits editor
>
> M  +57   -11   kmymoney/dialogs/kmymoneysplittable.cpp
> M  +19   -0    kmymoney/dialogs/kmymoneysplittable.h
> M  +1    -0    kmymoney/dialogs/ksplittransactiondlg.cpp
> M  +8    -1    kmymoney/dialogs/ksplittransactiondlg.h
> M  +1    -0    kmymoney/dialogs/transactioneditor.cpp
> M  +0    -1    kmymoney/reports/listtable.cpp
> M  +6    -0    kmymoney/reports/querytable.cpp
>
> https://commits.kde.org/kmymoney/c712d81154ef2fd5bb136bc4521ba3d046b74ba6
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
Comment 7 Ralf Habacker 2019-02-07 06:51:10 UTC
(In reply to Ralf Habacker from comment #5)
> Pushed by habacker into branch '4.8'.
Related review request for the recent ledger KF5 view is located at https://phabricator.kde.org/D18789.
Comment 8 Ralf Habacker 2019-02-08 15:23:09 UTC
Created attachment 117929 [details]
test file for ledger view

The appended test file could be used to check tag support in the ledger view
Comment 9 Ralf Habacker 2019-02-08 20:20:22 UTC
Git commit ca0f25eae22e3bc7f8362264183619d09af637cf by Ralf Habacker.
Committed on 08/02/2019 at 18:00.
Pushed by habacker into branch '4.8'.

Fix initial with of transaction split editor
FIXED-IN:4.8.4

M  +1    -1    kmymoney/dialogs/ksplittransactiondlgdecl.ui

https://commits.kde.org/kmymoney/ca0f25eae22e3bc7f8362264183619d09af637cf
Comment 10 Ralf Habacker 2019-03-24 13:21:24 UTC
Git commit c64a8c06e0a162aaf1030ed0fd99f6e01b67963d by Ralf Habacker.
Committed on 24/03/2019 at 13:20.
Pushed by habacker into branch '5.0'.

Add support for assigning tags in transaction splits editor

In the transaction split editor the tags column is designed similar
to categories and shows the assigned tags as text.
On editing a split a drop down box with all available tags and
checkboxes for removing assigned tags are visible.

Because tags are always assigned to splits, adding tags by the transaction
split editor works in the same way as adding tags in the ledger view.

Please note that the report engine is not able to filter
tags on categories yet.

Ported to KF5 from commit c712d81154ef2fd5bb136bc4521ba3d046b74ba6.
FIXED-IN:4.8.4,5.0.4
Reviewed By: tbaumgart
Differential Revision: https://phabricator.kde.org/D18789

M  +53   -11   kmymoney/dialogs/kmymoneysplittable.cpp
M  +10   -0    kmymoney/dialogs/kmymoneysplittable.h
M  +7    -0    kmymoney/dialogs/ksplittransactiondlg.cpp
M  +9    -0    kmymoney/dialogs/ksplittransactiondlg.h
M  +1    -1    kmymoney/dialogs/ksplittransactiondlg.ui
M  +0    -1    kmymoney/plugins/views/reports/core/listtable.cpp
M  +6    -0    kmymoney/plugins/views/reports/core/querytable.cpp

https://commits.kde.org/kmymoney/c64a8c06e0a162aaf1030ed0fd99f6e01b67963d