Bug 341445 - Instructions missing in asm-m68k.xml syntax file
Summary: Instructions missing in asm-m68k.xml syntax file
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: syntax (show other bugs)
Version: 3.14.0
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-30 19:26 UTC by Folco
Modified: 2014-12-14 15:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Patch fixing redundant instructions, and adding the missing ones (548 bytes, patch)
2014-12-01 22:12 UTC, Folco
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Folco 2014-11-30 19:26:02 UTC
Hi guys,

Using Kate 3.14.2 from Debian testing.
In the syntax file /usr/share/kde4/apps/katepart/asm-m68k.xml

- Instruction 'dbvc' is specified twice (lines 152 & 153 here)
- Instruction 'dbvs' is missing

- Instruction 'svc' is specified twice (lines 234 & 235 here)
- Instruction 'svs' is missing

Solution -> replacing the second 'dbvc' / 'svc' with 'dbvs' / 'svs' respectively fixes the problem.

Note: there is no problem for the couple 'bvc' / 'bvs'.
Comment 1 Folco 2014-12-01 22:12:20 UTC
Created attachment 89800 [details]
Patch fixing redundant instructions, and adding the missing ones

Eventually I found the KDE repository, so I could do a patch.
It applies against http://websvn.kde.org/trunk/KDE/kdelibs/kate/syntax/data/asm-m68k.xml?revision=1091064&view=markup&pathrev=1091064
Comment 2 Folco 2014-12-04 23:02:05 UTC
The patch applies to https://projects.kde.org/projects/kde/applications/kate/repository/revisions/c2a1c24f28613342985aa40573fb922370900a3a/entry/part/syntax/data/asm-m68k.xml , too...
I'm not very familiar yet with KDE repositories...
Comment 3 Christoph Feck 2014-12-12 22:41:51 UTC
Thanks for the patch.

This looks like a trivial fix that can get committed without going through further review.
Comment 4 Christoph Cullmann 2014-12-14 15:42:07 UTC
Git commit b8b3091629d7492ab464e46f42d165ea6c2dcbc2 by Christoph Cullmann.
Committed on 14/12/2014 at 15:41.
Pushed by cullmann into branch 'master'.

Instructions missing in asm-m68k.xml syntax file

M  +2    -2    src/syntax/data/asm-m68k.xml

http://commits.kde.org/ktexteditor/b8b3091629d7492ab464e46f42d165ea6c2dcbc2