Bug 341435 - No focus when opening the "Edit track CDDB info" dialog
Summary: No focus when opening the "Edit track CDDB info" dialog
Status: RESOLVED FIXED
Alias: None
Product: k3b
Classification: Applications
Component: GUI/Usability (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: k3b developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-30 09:40 UTC by martonmiklos
Modified: 2015-02-09 22:51 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Edit track CDDB details usability improvement patch (2.02 KB, patch)
2014-11-30 10:55 UTC, martonmiklos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description martonmiklos 2014-11-30 09:40:42 UTC
When opening the track's CDDB data none of the dialog's input get focus. 
It is annoying when every time have to click in the Title lineedit to type in the title of the track. 

Reproducible: Always

Steps to Reproduce:
1. Put in an audio CD
2. Select Tools -> Rip Audio CD 
3. Right click on a random track select Edit track CDDB info

Actual Results:  
None of the inputs get focus

Expected Results:  
The title should have a focus by default.
Comment 1 martonmiklos 2014-11-30 10:55:25 UTC
Created attachment 89776 [details]
Edit track CDDB details usability improvement patch

This patch contains the following modifications:
- Set the album CDDB dialog year's input to the current year if no year was specified before. (Who want to rip audio from year 1 by default ?)
- Set the default focus to the Title input in the track edit CDDB dialog.
- In the same dialog if no artist was specified before set the artist to the album's artist.
Comment 2 Albert Astals Cid 2014-11-30 20:44:02 UTC
Please use http://reviewboard.kde.org/ for patches
Comment 3 martonmiklos 2014-11-30 21:05:35 UTC
Done: https://git.reviewboard.kde.org/r/121297
Comment 4 Albert Astals Cid 2015-02-09 22:51:38 UTC
Git commit 9f9964d8a564a78152bdd1110cc496266412b651 by Albert Astals Cid, on behalf of Miklos Marton.
Committed on 09/02/2015 at 22:50.
Pushed by aacid into branch 'master'.

No focus on any inputs after opening the "Edit track CDDB info" dialog

When opening the track's CDDB data none of the dialog's input get focus. It is annoying to click in the Title lineedit to type in the title of the track every time.

This patch contains the following modifications:

    Set the album CDDB dialog year's input to the current year if no year was specified before. (Who want to rip audio from year 1 by default ?)
    Set the default focus to the Title input in the track edit CDDB dialog.
    In the same dialog if no artist was specified before set the artist to the album's artist.
REVIEW: 121297

M  +13   -1    src/rip/k3baudiocdview.cpp

http://commits.kde.org/k3b/9f9964d8a564a78152bdd1110cc496266412b651