Bug 341367 - Visual assets are outdated wrt/ Plasma 5 Breeze theming
Summary: Visual assets are outdated wrt/ Plasma 5 Breeze theming
Status: CONFIRMED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: frameworks
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks: 337512
  Show dependency treegraph
 
Reported: 2014-11-28 14:52 UTC by Eike Hein
Modified: 2020-10-08 23:34 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Hein 2014-11-28 14:52:03 UTC
- The copy of the Konversation app icon we have in the repo isn't updated to the Breeze version yet.

- The default nicklist theme doesn't use Breeze icons yet.

Reproducible: Always
Comment 1 Eike Hein 2014-11-28 15:09:43 UTC
VDG forum thread about a new version of the default nicklist theme: https://forum.kde.org/viewtopic.php?f=285&t=123868&p=325025
Comment 2 Eike Hein 2014-11-30 14:47:56 UTC
We have a Breeze nicklist theme now:

http://commits.kde.org/konversation/aa5fc5daa8adf5febf8ae9d2901b67f7c6c22f6f
http://commits.kde.org/konversation/08fe48b608e05008b370ab77aa745ceda43b4c3d

We'll revamp nicklist theming after Beta 1 to get rid of the mentioned hack and address bug 341364.
Comment 3 Friedrich W. H. Kossebau 2020-09-30 17:46:19 UTC
(In reply to Eike Hein from comment #2)
> We have a Breeze nicklist theme now:
> 
> http://commits.kde.org/konversation/aa5fc5daa8adf5febf8ae9d2901b67f7c6c22f6f
> http://commits.kde.org/konversation/08fe48b608e05008b370ab77aa745ceda43b4c3d
> 
> We'll revamp nicklist theming after Beta 1 to get rid of the mentioned hack
> and address bug 341364.

Eike, is there any chance you or someone remembers details of "We'll revamp nicklist theming after Beta 1 as discussed with the VDG"?

Would be happy to try to include that in the current efforts done with https://invent.kde.org/network/konversation/-/merge_requests/12


Also, the current Konversation icon looks similar, but not exactly the same as the one added to the Breeze icon set. Respective commits though were done both around the same days in July 2015, which leaves questions...

https://invent.kde.org/network/konversation/-/commit/c64d1cd32445f6921109fdbdb17ae44378d404c5 
vs.
https://invent.kde.org/frameworks/breeze-icons/-/blob/7ba9222ed7dc8b841c22542a137af0aa7f8df8f6/icons/apps/software/konversation.svg
Comment 4 Eike Hein 2020-10-08 23:34:18 UTC
frinring, revamp was probably re the hack in https://invent.kde.org/network/konversation/commit/08fe48b608e05008b370ab77aa745ceda43b4c3d