Bug 341343 - Kubuntu 14.10 plasma 5 doesn't give good notification when you try to drop something on the task manager instead of the panel
Summary: Kubuntu 14.10 plasma 5 doesn't give good notification when you try to drop so...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager widgets (show other bugs)
Version: 5.1.1
Platform: Kubuntu Linux
: NOR normal
Target Milestone: 1.0
Assignee: Sebastian Kügler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-28 04:59 UTC by mgolden
Modified: 2021-03-20 02:40 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:
aleixpol: Usability+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mgolden 2014-11-28 04:59:15 UTC
When I tried to add a trashcan to the bottom panel, I think I dropped it on the task manager.  It did not display a slashed icon, it simply didn't put the trashcan in.


Reproducible: Always
Comment 1 Aleix Pol 2015-01-08 16:25:05 UTC
We definitely want better visual feedback. Adding usability so they take it into account.
Comment 2 Bhushan Shah 2015-01-10 07:53:05 UTC
CC'ing Sho_ since task manager is involved
Comment 3 Eike Hein 2015-01-10 14:51:11 UTC
This is actually a bug in Plasma's DND components. They can't reject drags, they implicitly accept all of them. This also affects some scenarios in Folder View and numerous other Plasma UIs. How those components made it through API review originally is beyond me TBH.
Comment 4 Aleix Pol 2015-01-12 00:11:14 UTC
So we agree this should be ported to Qt's DropArea at least?

Maybe you can describe here more or less what needs to be done so we can easily tell somebody to do it? (assuming you don't plan to do it in a short-term)
Comment 5 Eike Hein 2015-01-12 12:21:52 UTC
> So we agree this should be ported to Qt's DropArea at least?

+1

I last tried porting it against Qt 5.2 git iirc, after the desktop DND revamp in Qt Quick. It wasn't viable at the time due to remaining API limitations; I'll have to try again and see what's missing.
Comment 6 Eike Hein 2015-01-12 16:12:35 UTC
Not looking that good right now. Qt Quick's DropArea only allows rejecting a drag in the onEntered handler, not in onPositionChanged, so it can't change its mind while the cursor moves. This would actually be a good enough for Task Manager, but not for Folder View, where the decision needs to be reevaluated depending on which icon is being hovered (meanwhile putting a DropArea into every delegate would increase their cost, causing a scalability concern).

However, rejecting a drag in onEntered currently also breaks the DropArea due to an open, stalled bug:
https://bugreports.qt.io/browse/QTBUG-39453
https://codereview.qt-project.org/#/c/88612/
Comment 7 Justin Zobel 2020-11-23 03:22:02 UTC
(In reply to Eike Hein from comment #6)
> Not looking that good right now. Qt Quick's DropArea only allows rejecting a
> drag in the onEntered handler, not in onPositionChanged, so it can't change
> its mind while the cursor moves. This would actually be a good enough for
> Task Manager, but not for Folder View, where the decision needs to be
> reevaluated depending on which icon is being hovered (meanwhile putting a
> DropArea into every delegate would increase their cost, causing a
> scalability concern).
> 
> However, rejecting a drag in onEntered currently also breaks the DropArea
> due to an open, stalled bug:
> https://bugreports.qt.io/browse/QTBUG-39453
> https://codereview.qt-project.org/#/c/88612/

It appears these were merged in 5.6, is it possible to revisit this bug, please?
Comment 8 Nate Graham 2021-03-20 02:40:55 UTC
Looks like this is actually working properly now. Trying to drag an icon on top of the Task Manager causes it to scoot out of the way a bit, indicating that the thing will be dropped on one end of it or the other, depending on where you move the cursor.