Since the unfree unrar version has reached version 1:5.2.1-1 (currently at 1:5.2.2-1) the tumbnail preview for .cbr files failed, showing only the default document icon instead. Since okular had also been unable to open .cbr files since that point, i assumed a similar problem. Turns out, that since the mentioned version, unrar dropped the --version flag, leaving us only with the -v flag to identify it. That suspicion was hardened by the fact since thumbnails were created as usual after a downgrade to unrar 1:5.1.7-1. Based on the solution for okular from Albert Astals Cid i wrote a patch which implements a fallback check to the -v flag if the --version flag fails. Only if both checks fail, no unrar path is returned. Reproducible: Always Steps to Reproduce: 1. Start kde while unrar 1:5.2.2-1 or higher is installed. 2. Make sure Comicbook preview in Dolphin is enabled. 3. Navigate to a folder with at least one .cbr in it which has not yet gotten a thumbnail. (Cached thumbnails will continue to work). Actual Results: Missing .cbr thumbnails will not be created. Expected Results: New .cbr files getting their previews. I will add my patch to this report. It has compiled without problems on my system with the code from the kde-runtime project as a base. I branched it from v4.14.3 of the repository. After i restarted the patched kde, .cbr thumbnail production worked with both versions.
Created attachment 89736 [details] Proposed patch to fix the bug.
Thanks Jörg for the patch. There are some coding style issues which are best discussed at reviewboard.kde.org. If you do not want to create a review request there, I will go through it in the coming days.
This is still an issue in Dolphin 15.08
*** Bug 355368 has been marked as a duplicate of this bug. ***
This bug still exists in Dolphin 15.12.2
I just submitted a patch for this https://git.reviewboard.kde.org/r/129255/
Git commit c734c5d5a1b47f749ef9230454f963b3b7daf573 by Albert Astals Cid. Committed on 20/01/2017 at 23:13. Pushed by aacid into branch 'Applications/16.12'. Fixed unrar version check The parameter "--version" stopped working since unrar 5.2 which was released almost 2 years ago. With this change this now becomes the minimum version required but every distribution that is going to relase a version with this commit has probably been using unrar > 5.2 for quite a while so I don't think there is any need to provide a fallback. Related: bug 367626 REVIEW: 129255 M +1 -1 thumbnail/comiccreator.cpp https://commits.kde.org/kio-extras/c734c5d5a1b47f749ef9230454f963b3b7daf573