Bug 341263 - Don't hardcode smbd executable paths in ksambashare.cpp
Summary: Don't hardcode smbd executable paths in ksambashare.cpp
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: David Faure
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2014-11-25 18:01 UTC by Ivailo Monev
Modified: 2020-05-30 14:04 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/kio/commit/c494d1b608622c842c4d61fa54b87db2e93c0eef
Version Fixed In: 5.71.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Ivailo Monev 2014-11-25 18:01:11 UTC 
In the KIO slave KSambaSharePrivate::isSambaInstalled() looks only for /usr/sbin/smbd and /usr/local/sbin/smbd, this is not the best thing to do. It may be sufficient for most distributions but it will most likely not fit all and I suggest the use of KStandardDirs::findExe(). If nothing else, at least make sure that the current check does check if the paths are also executable and not only existing (the current check is just QFile::exists()).

Cheers!

Reproducible: Always
Comment 1 David Faure 2020-05-30 14:04:16 UTC 
Git commit c494d1b608622c842c4d61fa54b87db2e93c0eef by David Faure, on behalf of Ahmad Samir.
Committed on 30/05/2020 at 14:04.
Pushed by dfaure into branch 'master'.

[KSambaShare] Check that both smbd and testparm are available

This way we check that both the samba daemon and samba-client are
available on the system.
FIXED-IN: 5.71.0

M  +11   -5    src/core/ksambashare.cpp

https://invent.kde.org/frameworks/kio/commit/c494d1b608622c842c4d61fa54b87db2e93c0eef