Bug 341255 - Tray doesn't seem to be using the attention icon specified by status notifier items
Summary: Tray doesn't seem to be using the attention icon specified by status notifier...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: System Tray (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Sebastian Kügler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-25 15:40 UTC by Eike Hein
Modified: 2019-11-05 13:55 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Hein 2014-11-25 15:40:51 UTC
Konversation calls KStatusNotifierItem::setAttentionIconByName("konv_message"), and konv_message.svgz exists in desktoptheme/breeze/icons, but it's not showing up in the system tray. Instead, the original icon is pulsing. But it's important the attention icon be used since it uses a more noticable color.

Reproducible: Always
Comment 1 Eike Hein 2014-11-25 15:43:34 UTC
Seems to also happen for Quassel, which uses a slightly different setup (instead of different SVGs it has all elements in one and probably passes them as pixmap instead of by name).
Comment 2 Ian Pilcher 2017-08-25 17:20:13 UTC
Just ran across this when I decided to dig in and stop missing messages.

Any chance that someone can look at this?
Comment 3 Konrad Materka 2019-10-19 08:14:11 UTC
Git commit 51964243ad402224fbe3ccbc2aeaec4d0420d2b6 by Konrad Materka.
Committed on 19/10/2019 at 08:13.
Pushed by kmaterka into branch 'master'.

[SystemTray] Support for AttentionIcon

Summary:
Adding support for Attention Icon to StatusNotifier tray icons

Test Plan: As described in bug report, Konversation can be used for tests.

Reviewers: #plasma, davidedmundson, apol, mart, ngraham

Reviewed By: #plasma, davidedmundson, ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24767

M  +5    -0    applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

https://commits.kde.org/plasma-workspace/51964243ad402224fbe3ccbc2aeaec4d0420d2b6
Comment 4 Konrad Materka 2019-11-05 13:55:09 UTC
Git commit 2d7b6c2324c39b2ba116a6be5f83a1e5b2ec6231 by Konrad Materka.
Committed on 05/11/2019 at 13:43.
Pushed by kmaterka into branch 'master'.

[SystemTray] Support for AttentionIcon

Summary:
Adding support for Attention Icon to StatusNotifier tray icons.
Binding is working correctly only when "Status" is used, not derived "status".

Test Plan: As described in bug report, Konversation can be used for tests.

Reviewers: #plasma, broulik, #plasma_workspaces

Reviewed By: #plasma, broulik, #plasma_workspaces

Subscribers: lbeltrame, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24865

M  +12   -6    applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
M  +2    -2    dataengines/statusnotifieritem/statusnotifieritemsource.cpp

https://commits.kde.org/plasma-workspace/2d7b6c2324c39b2ba116a6be5f83a1e5b2ec6231