Bug 341254 - Time strings need plural forms
Summary: Time strings need plural forms
Status: REPORTED
Alias: None
Product: frameworks-kcoreaddons
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Michael Pyne
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-25 14:55 UTC by fios
Modified: 2021-06-19 09:49 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description fios 2014-11-25 14:55:42 UTC
The time strings for days, hours, minuted etc. would profit from having proper plural forms. Since QML allows for proper plural forms, can this also be implemented here?

In case I got the wrong module, I am talking about
http://websvn.kde.org/trunk/l10n-kf5/templates/messages/frameworks/kcoreaddons5_qt.pot?view=log
Comment 1 Burkhard Lück 2014-11-26 06:48:56 UTC
Please quote the messages in question
Comment 2 fios 2014-11-26 07:19:57 UTC
Here they are:

#. @item:intext %1 is a real number, e.g. 1.23 days
#: lib/util/kformatprivate.cpp:269
#, qt-format
msgctxt "KFormat|"
msgid "%1 days"
msgstr ""

#. @item:intext %1 is a real number, e.g. 1.23 hours
#: lib/util/kformatprivate.cpp:272
#, qt-format
msgctxt "KFormat|"
msgid "%1 hours"
msgstr ""

#. @item:intext %1 is a real number, e.g. 1.23 minutes
#: lib/util/kformatprivate.cpp:275
#, qt-format
msgctxt "KFormat|"
msgid "%1 minutes"
msgstr ""

#. @item:intext %1 is a real number, e.g. 1.23 seconds
#: lib/util/kformatprivate.cpp:278
#, qt-format
msgctxt "KFormat|"
msgid "%1 seconds"
msgstr ""

#. @item:intext %1 is a whole number
#: lib/util/kformatprivate.cpp:283
#, qt-format
msgctxt "KFormat|"
msgid "%n millisecond(s)"
msgid_plural "%n millisecond(s)"
msgstr[0] ""

#. @item:intext %n is a whole number
#: lib/util/kformatprivate.cpp:301
#, qt-format
msgctxt "KFormat|"
msgid "%n day(s)"
msgid_plural "%n day(s)"
msgstr[0] ""

#. @item:intext %n is a whole number
#: lib/util/kformatprivate.cpp:306
#, qt-format
msgctxt "KFormat|"
msgid "%n hour(s)"
msgid_plural "%n hour(s)"
msgstr[0] ""

#. @item:intext %n is a whole number
#: lib/util/kformatprivate.cpp:311
#, qt-format
msgctxt "KFormat|"
msgid "%n minute(s)"
msgid_plural "%n minute(s)"
msgstr[0] ""

#. @item:intext %n is a whole number
#: lib/util/kformatprivate.cpp:316
#, qt-format
msgctxt "KFormat|"
msgid "%n second(s)"
msgid_plural "%n second(s)"
msgstr[0] ""
Comment 3 fios 2014-11-26 10:54:26 UTC
Same problem in http://websvn.kde.org/trunk/l10n-kf5/templates/messages/frameworks/kdelibs4support.pot?view=log

#: kdecore/klocale_kde.cpp:1472
#, kde-format
msgctxt "@item:intext %1 is a real number, e.g. 1.23 days"
msgid "%1 days"
msgstr ""

#: kdecore/klocale_kde.cpp:1475
#, kde-format
msgctxt "@item:intext %1 is a real number, e.g. 1.23 hours"
msgid "%1 hours"
msgstr ""

#: kdecore/klocale_kde.cpp:1478
#, kde-format
msgctxt "@item:intext %1 is a real number, e.g. 1.23 minutes"
msgid "%1 minutes"
msgstr ""

#: kdecore/klocale_kde.cpp:1481
#, kde-format
msgctxt "@item:intext %1 is a real number, e.g. 1.23 seconds"
msgid "%1 seconds"
msgstr ""

#: kdecore/klocale_kde.cpp:1484
#, kde-format
msgctxt "@item:intext"
msgid "%1 millisecond"
msgid_plural "%1 milliseconds"
msgstr[0] ""
msgstr[1] ""

#: kdecore/klocale_kde.cpp:1491
#, kde-format
msgctxt "@item:intext"
msgid "1 day"
msgid_plural "%1 days"
msgstr[0] ""
msgstr[1] ""

#: kdecore/klocale_kde.cpp:1493
#, kde-format
msgctxt "@item:intext"
msgid "1 hour"
msgid_plural "%1 hours"
msgstr[0] ""
msgstr[1] ""

#: kdecore/klocale_kde.cpp:1495
#, kde-format
msgctxt "@item:intext"
msgid "1 minute"
msgid_plural "%1 minutes"
msgstr[0] ""
msgstr[1] ""

#: kdecore/klocale_kde.cpp:1497
#, kde-format
msgctxt "@item:intext"
msgid "1 second"
msgid_plural "%1 seconds"
msgstr[0] ""
msgstr[1] ""
Comment 4 Burkhard Lück 2014-11-26 17:55:19 UTC
I am not sure if the first four messages with msgctxt "@item:intext %1 is a real number, e.g. 1.23 days" require plurals in some languages, please ask the translation teams on kde-i18n-doc@kde.org

The last five examples (with "%1 is a whole number") have a plural for all languages, but in en_US (=msgstr) it looks a bit strange
Comment 5 fios 2014-11-26 18:44:15 UTC
Floating point numbers require plural forms in my language. http://unicode.org/cldr/trac/ticket/7510
Comment 6 fios 2014-12-09 10:33:34 UTC
I just had another look at this series:

    #. @item:intext %1 is a whole number
    #: lib/util/kformatprivate.cpp:283
    #, qt-format msgctxt "KFormat|"
    msgid "%n millisecond(s)"
    msgid_plural "%n millisecond(s)"

They can be translated properly, but the English source is wrong, they should look like this:

    msgid "%n millisecond"
    msgid_plural "%n milliseconds"
Comment 7 Justin Zobel 2021-03-09 05:54:04 UTC
Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.