Bug 341181 - Mozilla/XUL application list is missing some applications, leading to crashes
Summary: Mozilla/XUL application list is missing some applications, leading to crashes
Status: CONFIRMED
Alias: None
Product: Oxygen
Classification: Plasma
Component: gtk2-engine (show other bugs)
Version: unspecified
Platform: Other Other
: NOR crash
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-22 14:42 UTC by aleth
Modified: 2022-12-07 18:47 UTC (History)
9 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description aleth 2014-11-22 14:42:07 UTC
The Oxygen-gtk engine contains (at least one) list of XUL applications, which are then handled differently. E.g. inside oxygenapplicationname.cpp there is

// tag all mozilla-like applications (XUL)
static const std::string XulAppNames[] =
{
    "firefox",
    "thunderbird",
    "seamonkey",
    "iceweasel",
    "icecat",
    "icedove",
    "xulrunner",
    "komodo",
    "aurora",
    "zotero",
    ""
};

This list is missing some XUL application names, causing those apps to crash: see
https://bugzilla.mozilla.org/show_bug.cgi?id=1062145
https://bugzilla.mozilla.org/show_bug.cgi?id=985986

Please add "instantbird" and "earlybird" to this list!  (And seeing that "aurora" is listed, I wonder if "nightly" and "firefoxdeveloperedition" need to be listed too, but maybe those fall under "firefox").

Reproducible: Always
Comment 1 Hugo Pereira Da Costa 2014-11-22 16:01:52 UTC
@Ruslan
This list is becomming longer by the day
I guess we should put it in an external config file ... Agreed ? If yes I'll do that
This will cause some overhead at startup but is more easily fixed by user ...

Too bad XUL does not provide a way (that I know of) to be identified externally
Comment 2 Ruslan Kabatsayev 2014-11-22 16:13:02 UTC
This seems too specific to XUL. Could we instead file a bug report to Mozilla and ask for an application-independent way to detect XUL?
Comment 3 Moonchild 2014-11-22 16:35:26 UTC
An application-independent way to detect XUL and prevent these crashes would be awesome.
As it is, I'm having issues with my own re-branded version because it is also not in the list above.

e.g.:
https://forum.palemoon.org/viewtopic.php?f=37&t=5863&hilit=oxygen+gtk
https://forum.palemoon.org/viewtopic.php?f=37&t=5059&hilit=oxygen+gtk

It would need "palemoon" and "newmoon" added (official and unofficial branding, respectively). Currently users are forced to change theme to something that doesn't crash manually.
Comment 4 Hugo Pereira Da Costa 2014-11-22 16:37:21 UTC
yeah.
Alternatively we could find a way to detect loaded libraries at runtime, like libXul or something.
Possibly look-up a symbol that is XUL specific. I believe this is doable but have never found time to investigate further ...
Comment 5 aleth 2015-01-30 19:44:45 UTC
It would be nice if this were fixed soon by adding the missing app names, rather than waiting indefinitely until someone finds the time for a more perfect solution.
Comment 6 Moonchild 2015-07-18 09:08:26 UTC
We're still running into this issue. Can we please get a short-term solution by adding the missing application names, since there's obviously no progress on an alternative solution and crashes=bad? We're getting a lot of unnecessary support traffic on the forum because of this, with many less-technical Linux users being unsure what to do except switch to a different application that doesn't crash.

It should be fairly simple to add the application names and push out an update to at least extend this functionality to known XUL applications until this is addressed differently?
So, please add: 
"instantbird"
"earlybird"
"nightly" (maybe?)
"firefoxdeveloperedition" (maybe?)
"palemoon"
"newmoon"
"fossamail" (xul-based mail client)
Comment 7 Nick Stefanov 2015-07-18 09:52:03 UTC
Yes, please solve this problem. Pale Moon is award winning browser and it maust be officially supported.
Comment 8 Hugo Pereira Da Costa 2015-07-18 18:13:37 UTC
Git commit b1ee5fb80c44c6c8a625333af1cfdc997d408805 by Hugo Pereira Da Costa.
Committed on 18/07/2015 at 18:09.
Pushed by hpereiradacosta into branch '1.4'.

moved xul application names to dedicated header file,
added a number of xul applications to prevent crash for these

M  +2    -16   src/oxygenapplicationname.cpp
A  +56   -0    src/oxygenxulapplicationnames.h     [License: LGPL (v2+)]

http://commits.kde.org/oxygen-gtk/b1ee5fb80c44c6c8a625333af1cfdc997d408805
Comment 9 hermsenk 2017-08-21 15:18:46 UTC
I have the exact same issue with using oxygen theme in kde and palemoon browser. The browser will open; however, when you hoover the mouse over the menu it's like looking through a glass window and when you click on anything in the menu at times the browser will close. You will have to change your theme to a gtk based theme!
Comment 10 Justin Zobel 2020-12-04 03:55:30 UTC
Thank you for the report.

As it has been a while since this was reported, can you please test and confirm if this issue is still occurring or if this bug report can be marked as resolved.

I have set the bug status to "needsinfo" pending your response, please change back to "reported" or "resolved/worksforme" when you respond, thank you.
Comment 11 Moonchild 2020-12-04 10:45:27 UTC
As one might expect, if this hasn't been fixed in the engine yet via feature detection, then the binary names list needs to be updated.
Most of the users of our software have wisened up enough to search for the problem and switch to a different theme engine, but it's obviously not ideal.
Missing at the very least are "basilisk" "serpent" "ambassador" and "interlink" from our community corner -- I'm sure there are more forks of various XUL applications around.
Comment 12 Bug Janitor Service 2020-12-19 04:34:55 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 13 Moonchild 2020-12-19 09:42:47 UTC
Apologies for not manually changing the status when replying.
Please see https://bugs.kde.org/show_bug.cgi?id=341181#c11
Comment 14 Justin Zobel 2022-11-21 08:11:52 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 15 Bug Janitor Service 2022-12-06 05:16:25 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 16 Moonchild 2022-12-07 09:55:05 UTC
I've asked our users to let me know if this is still an issue. If you did not make any significant changes to the engine I'd assume this is still a problem on any UXP-based software, but have asked for people to verify. I'm sure most users who ran into this issue have simply switched to a non-oxygen engine a long time ago as that is what we have been suggesting to work around it.

I'll report back when I have an answer to this on https://forum.palemoon.org/viewtopic.php?f=5&t=29169
Comment 17 Moonchild 2022-12-07 17:19:22 UTC
Confirmed it still crashes.