Bug 341008 - Needs some more spacing on the sides
Summary: Needs some more spacing on the sides
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Digital Clock (show other bugs)
Version: 5.1.1
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Martin Klapetek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-15 22:58 UTC by Albert Astals Cid
Modified: 2014-11-20 11:52 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot (67.61 KB, image/png)
2014-11-15 22:58 UTC, Albert Astals Cid
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Astals Cid 2014-11-15 22:58:11 UTC
Created attachment 89605 [details]
Screenshot

See the attached screenshot, the clock feels a bit too much close to the border. Maybe it's just one pixel more i'd need.
Comment 1 Martin Klapetek 2014-11-17 11:25:12 UTC
Interesting. When the panel is not maximized, there is almost enough padding so it does not look as bad. I wonder if maximized panels should have some inner padding at the sides...

Will try to fix it from the clock applet.
Comment 2 Marco Martin 2014-11-17 16:08:27 UTC
Git commit 2dc1e6d6a7397067d13905dd14ea1b2bbc40b32f by Marco Martin.
Committed on 17/11/2014 at 17:06.
Pushed by mart into branch 'master'.

set thr right margin too

M  +1    -1    desktoppackage/contents/views/Panel.qml

http://commits.kde.org/plasma-desktop/2dc1e6d6a7397067d13905dd14ea1b2bbc40b32f
Comment 3 Albert Astals Cid 2014-11-17 19:38:16 UTC
Marco can we get that backported to Plasma 5.1 branch?

Also not an expert at all of the code myself but it feels a bit weird using 
root.fixedMargins.bottom for anchors.rightMargin 

Cheers,
  Albert

El Dilluns, 17 de novembre de 2014, a les 16:08:27, Marco Martin va escriure:
> https://bugs.kde.org/show_bug.cgi?id=341008
> 
> Marco Martin <notmart@gmail.com> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
> Resolution|---                         |FIXED
>              Status|CONFIRMED                   |RESOLVED
>       Latest Commit|                            |http://commits.kde.org/plas
>                    |                            |ma-desktop/2dc1e6d6a7397067
>                    |                            |d13905dd14ea1b2bbc40b32f
> 
> --- Comment #2 from Marco Martin <notmart@gmail.com> ---
> Git commit 2dc1e6d6a7397067d13905dd14ea1b2bbc40b32f by Marco Martin.
> Committed on 17/11/2014 at 17:06.
> Pushed by mart into branch 'master'.
> 
> set thr right margin too
> 
> M  +1    -1    desktoppackage/contents/views/Panel.qml
> 
> http://commits.kde.org/plasma-desktop/2dc1e6d6a7397067d13905dd14ea1b2bbc40b3
> 2f
Comment 4 Martin Klapetek 2014-11-20 11:47:11 UTC
Git commit 679a4dcd1a3ca6fade91adf7507e1a4d5458eabd by Martin Klapetek.
Committed on 20/11/2014 at 11:46.
Pushed by mklapetek into branch 'master'.

[desktop/views] Right margins should be counted using fixedMargins.right not .bottom

M  +1    -1    desktoppackage/contents/views/Panel.qml

http://commits.kde.org/plasma-desktop/679a4dcd1a3ca6fade91adf7507e1a4d5458eabd
Comment 5 Martin Klapetek 2014-11-20 11:52:02 UTC
Git commit 570732bf7a8c56c88614f3be15ad5d3341fa86a0 by Martin Klapetek.
Committed on 20/11/2014 at 11:51.
Pushed by mklapetek into branch 'Plasma/5.1'.

[desktop/views] Set right margin properly

This was setting the left margin twice, probably a typo.

M  +1    -1    desktoppackage/contents/views/Panel.qml

http://commits.kde.org/plasma-desktop/570732bf7a8c56c88614f3be15ad5d3341fa86a0