Bug 340948 - Crash when undoing a 16 bits float to 8 bits color space conversion
Summary: Crash when undoing a 16 bits float to 8 bits color space conversion
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Color models (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Other
: NOR crash
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-14 08:09 UTC by Tyson Tan
Modified: 2016-07-06 12:36 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Backtrace of the crash when undoing a 16 bits float to 8 bits conversion (24.51 KB, text/plain)
2014-11-14 08:10 UTC, Tyson Tan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2014-11-14 08:09:20 UTC
When testing Bug 340947, I converted a 16 bits float document to 8 bits and then undid such operation. Krita crashed during the undoing action. It only happened once today, but it happened before. I will attach the crash report later.

Reproducible: Sometimes
Comment 1 Tyson Tan 2014-11-14 08:10:38 UTC
Created attachment 89577 [details]
Backtrace of the crash when undoing a 16 bits float to 8 bits conversion
Comment 2 Halla Rempt 2014-12-09 15:35:24 UTC
Hm... Looksl like a a timing issue. Thos are nasty :-(
Comment 3 Dmitry Kazakov 2014-12-26 17:08:58 UTC
Hi, Tyson!

Do you remember what was the size of the image? Was it huge? 

The backtrace tells you were trying to close the image when the crash happened, could you clarify what exactly happened before Krita crashed?
Comment 4 Tyson Tan 2014-12-29 04:29:04 UTC
Hi Dmitry.

The document was slightly larger than A4 300 dpi, it had 3 to 5 layers, all in Normal blending mode, Except for the character layer, other layers were either small or filled with one color. The coloring was super flat as well. Normally I wouldn't consider that to be "huge". But it was in 16 bits, the conversion itself took a while to finish. I guess it was heavy in that regard.

I cannot recall the details, but I'm sure I didn't close Krita myself. Logically speaking, when a message box pops up, there is no way for me to close Krita manually but still getting the crash reporter, I think. Sometimes Krita crashes silently without showing any message box. This is probably a silent crash, otherwise I would have include the error message in the original report.
Comment 5 Halla Rempt 2016-04-16 13:20:59 UTC
Hi Tyson,

Have you seen this happen more than once?
Comment 6 Tyson Tan 2016-04-17 11:10:47 UTC
When I reported this, it must have happened multiple times. But during the making of that Kiki picture with cityscape, Krita color management problem caused great loss, I therefore reverted to the safest sRGB 8Bit approach. Haven't been testing this bug since.
Comment 7 Scott Petrovic 2016-05-21 23:15:29 UTC
I am on the RC1 on Windows 10 that was released on 5/21/16. 

I tried doing a few tests to undo color space changes. I couldn't get any crashes happening. I tried a few different configurations of converting and undoing, but couldn't get any crashes. It might be linux specific though.
Comment 8 Raghavendra kamath 2016-05-24 18:55:50 UTC
I am on arch linux plasma 5 , with an updated build from git.
the image dimension is 5260x7440

I convert an already existing 16 bit document to 16 bit float , then converted it to 8 bit , and then hit undo, it didn't crash for me.

It did take a long while and used all the 16 gb memeory and some swap while  the process, 
I tried it several tried it didn't crash for me
Comment 9 Halla Rempt 2016-07-06 12:36:02 UTC
I actually think I know what's going on... The crash happens when trying to close the image while the conversion is still going on. In the backtrace, there's a stacktrace for the thread where the image is deleted, and several that are still updating the canvas. But Dmitry redid that logic for 3.0, so it shouldn't be possible anymore.