Bug 340459 - Actual crop size is 1x1 pixel smaller than visualized
Summary: Actual crop size is 1x1 pixel smaller than visualized
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (other bugs)
Version First Reported In: Other (add details in bug description)
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-29 13:15 UTC by Alexander Potashev
Modified: 2017-05-12 18:20 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/gwenview/5b0749f6d60f40e91ae930bac604c7e77074c11f
Version Fixed/Implemented In: 17.04.2
Sentry Crash Report:

Attachments
screenshot (80.85 KB, image/png)
2014-10-29 13:17 UTC, Alexander Potashev 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2014-10-29 13:15:15 UTC 
Two problems actually:
 1. For example, if you open a 10x10 pixels and use Crop tool, the initial size of the cropping frame is 11x11 - 1 pixel past the right edge of image and 1 pixel past the bottom edge of the image.
 2. If you actually use the Crop tool, it crops one column more on the right and one column more in the bottom than you actually selected.

Reproducible: Always




"Gwenview 4.14.0 pre" on Fedora 20.
Comment 1 Alexander Potashev 2014-10-29 13:17:06 UTC 
Created attachment 89359 [details]
screenshot

Note the size as shown in the bar on the bottom is 3x3, but the cropping frame on the image is rather 4x4 pixels.
Comment 2 Christoph Feck 2017-05-12 18:20:32 UTC 
Git commit 5b0749f6d60f40e91ae930bac604c7e77074c11f by Christoph Feck.
Committed on 12/05/2017 at 18:18.
Pushed by cfeck into branch 'Applications/17.04'.

Fix crop region size
FIXED-IN: 17.04.2

M  +3    -4    lib/crop/croptool.cpp

https://commits.kde.org/gwenview/5b0749f6d60f40e91ae930bac604c7e77074c11f