Bug 340257 - Problematic defaults for icon-only tabs in Qt4 Breeze style
Summary: Problematic defaults for icon-only tabs in Qt4 Breeze style
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: QStyle (other bugs)
Version First Reported In: 5.1.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-23 12:55 UTC by Jarosław Staniek
Modified: 2014-10-23 23:47 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
The tab in Oxygen Qt4 style (6.18 KB, image/png)
2014-10-23 13:03 UTC, Jarosław Staniek
Details
The buggy tab in Breeze Qt4 style (4.86 KB, image/png)
2014-10-23 13:05 UTC, Jarosław Staniek
Details
.ui test with icon (1.04 KB, application/x-compressed-tar)
2014-10-23 13:16 UTC, Jarosław Staniek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jarosław Staniek 2014-10-23 12:55:47 UTC
Hi, The Qt4 backport shines already! One remark, icon-only tabs are possible without any QStyle proxy hacks with all known QStyles known to me (even bespin).

In Breeze it's like in the attachment. I would be grateful for setting metrics that fit like in Oxygen or so. It'll result in a rectangular tab, what's looks OK HIG-wise.


Reproducible: Always
Comment 1 Jarosław Staniek 2014-10-23 13:03:04 UTC
Created attachment 89279 [details]
The tab in Oxygen Qt4 style
Comment 2 Jarosław Staniek 2014-10-23 13:05:08 UTC
Created attachment 89280 [details]
The buggy tab in Breeze Qt4 style
Comment 3 Jarosław Staniek 2014-10-23 13:16:44 UTC
Created attachment 89281 [details]
.ui test with icon

please unpack somewhere and open in Designer, then preview in Breeze and Oxygen style
Comment 4 Hugo Pereira Da Costa 2014-10-23 15:24:04 UTC
Git commit a23a1cdeed9990407fc93b191422245e9948e4c5 by Hugo Pereira Da Costa.
Committed on 23/10/2014 at 11:03.
Pushed by hpereiradacosta into branch 'Plasma/5.1'.

- cleanup tab buttons positioning
- center icon in tabs when there is no text and no buttons

M  +1    -0    kstyle/breeze.h
M  +108  -4    kstyle/breezestyle.cpp
M  +2    -0    kstyle/breezestyle.h

http://commits.kde.org/breeze/a23a1cdeed9990407fc93b191422245e9948e4c5
Comment 5 Hugo Pereira Da Costa 2014-10-23 15:24:05 UTC
Git commit 4fca8df68105e7d5415f3964255a3c568212baf8 by Hugo Pereira Da Costa.
Committed on 23/10/2014 at 11:03.
Pushed by hpereiradacosta into branch 'master'.

- cleanup tab buttons positioning
- center icon in tabs when there is no text and no buttons

M  +1    -0    kstyle/breeze.h
M  +108  -4    kstyle/breezestyle.cpp
M  +2    -0    kstyle/breezestyle.h

http://commits.kde.org/breeze/4fca8df68105e7d5415f3964255a3c568212baf8
Comment 6 Hugo Pereira Da Costa 2014-10-23 15:25:24 UTC
thanks for the report
fixed now (I think)
will port to 'new' oxygen too
(for the record the previous behavior was inherited from QCommonStyle)
Comment 7 Jarosław Staniek 2014-10-23 23:47:03 UTC
Beautiful and so quickly! Thanks Hugo.
Fixed look in Kexi: http://wstaw.org/m/2014/10/24/plasma-desktopaC3906.png