Bug 340206 - do not use Version from org.freedesktop.systemd1.Manager in checkSystemdVersion
Summary: do not use Version from org.freedesktop.systemd1.Manager in checkSystemdVersion
Status: RESOLVED FIXED
Alias: None
Product: Powerdevil
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Development Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-21 17:28 UTC by Török Edwin
Modified: 2014-12-16 20:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Török Edwin 2014-10-21 17:28:32 UTC 
According to the documentation [0] Version is not part of the API and "it should not be parsed, one may not assume the version to be formatted in any particular way.".

However checkSystemdVersion() in ./powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp uses Version.

The problem is that systemd-shim doesn't implement version, and this results in the loss of the Sleep/Hibernate buttons from the KDE menu (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=747180).

Although it is rather simple to implement 'Version' in systemd-shim, I don't know if that should be done given that the documentation says it should not be used in the first place.

[0] http://www.freedesktop.org/wiki/Software/systemd/dbus/

Reproducible: Always
Comment 1 Kai Uwe Broulik 2014-12-16 20:50:26 UTC 
Those checks have been removed since the versions that were checked for have been released to years ago.