Bug 340186 - GROUP : Wallet icon for grouped photos is conceptually confusing
Summary: GROUP : Wallet icon for grouped photos is conceptually confusing
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-ItemGroup (show other bugs)
Version: 4.5.0
Platform: Other All
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-21 07:36 UTC by Dmitri Popov
Modified: 2017-07-29 05:27 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.5.0


Attachments
image-stack group icon rendering (186.83 KB, image/png)
2014-10-21 11:20 UTC, caulier.gilles
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitri Popov 2014-10-21 07:36:28 UTC
Using the wallet icon for grouped photos seems like a poor choice for several reasons. Firstly, it's conceptually incorrect: photos are not put in wallet, they are grouped. Secondly, it's confusing: the wallet icon belongs to financial applications, so it's strange to see it in digiKam.

I think it would make more sense to either return to original icon or replace the wallet icon with something more appropriate (like a stack icon).

Reproducible: Always
Comment 1 caulier.gilles 2014-10-21 07:51:30 UTC
Well, please look in Oxygen icon set to see if you fion a better one.

The reason to use Wallet icon is to improve visibility (another closed report). The previous one wasn't really visible.

Gilles Caulier
Comment 2 Dmitri Popov 2014-10-21 08:21:29 UTC
How about a folder icon like this one: http://www.iconarchive.com/show/oxygen-icons-by-oxygen-icons.org/Places-folder-orange-icon.html

Another possibility is the emblem icon: http://www.iconarchive.com/show/oxygen-icons-by-oxygen-icons.org/Emblems-emblem-new-icon.html It's bright and visible and generic enough, so it won't be confusing.
Comment 3 caulier.gilles 2014-10-21 08:27:44 UTC
Emblem icon is to near Rating icon.

Orange icon exist in Oxygen. Look into your distro like :

/usr/share/icons/oxygen/32x32/places/

You must have a file named folder-orange.png

Gilles Caulier
Comment 4 caulier.gilles 2014-10-21 08:29:14 UTC
Perhaps folder-tar.png Oxygen icon is more appropriate ?

Gilles Caulier
Comment 5 Dmitri Popov 2014-10-21 09:03:11 UTC
folder-tar.png is a good choice.
Comment 6 caulier.gilles 2014-10-21 10:22:29 UTC
This is another problem.

Code need 2 icons : one indicating group not expanded (closed), and one indicating group expanded (open as all grouped items are visible on icon-view).

Look code here :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/widgets/itemview/itemviewimagedelegate.cpp#L531

Gilles Caulier
Comment 7 Dmitri Popov 2014-10-21 10:27:01 UTC
I see. What about folder-documents.png when the group is not expanded (closed) and folder-blue.png when the group is expanded?
Comment 8 caulier.gilles 2014-10-21 10:44:12 UTC
folder-documents.png can be not blue if icons them is different than Oxygen.

There are folder-open.png to replace folder-blue.png, but the difference is not too much visible with folder-documents.png with Oxygen theme.

Gilles
Comment 9 Dmitri Popov 2014-10-21 10:49:01 UTC
What do you think about image-stack.png (closed group) and image-stack-open.png (expanded group)?
Comment 10 caulier.gilles 2014-10-21 10:58:44 UTC
These icons have good contents but not too much visible : there is too much transparency here... 

We need a background for these icon to improve visibility

Gilles
Comment 11 Dmitri Popov 2014-10-21 11:04:17 UTC
If it's possible to add a background to the icons, then I'm all for it. :-) Otherwise, I guess the wallet icon are the only sensible solution. In any case, thank you, Gilles, for following up on this issue!

Best,
Dmitri
Comment 12 caulier.gilles 2014-10-21 11:10:05 UTC
We can add a background. The question is which one ?

Technically, we can merge 2 icon together.

A solid color ? Not too elegant. 
Another icon ? Which one ?

Gilles Caulier
Comment 13 Dmitri Popov 2014-10-21 11:14:44 UTC
I'm not a graphic designer, but I could try to make a few mockups.
Comment 14 caulier.gilles 2014-10-21 11:20:15 UTC
Created attachment 89229 [details]
image-stack group icon rendering
Comment 15 caulier.gilles 2014-10-21 11:21:28 UTC
Also, we need to take a care about digiKam color theme used. Try a black based theme for example, and look if icon still well visible.

Gilles Caulier
Comment 16 Dmitri Popov 2014-10-21 11:23:18 UTC
I actually think that the icons in the attached mockup look okay. Is it possible to display numbers under the icons?
Comment 17 caulier.gilles 2014-10-21 11:25:51 UTC
The items number into the stack is already displayed over the icon. There is not too much space to place number on top/bottom/left/right corner of icon.

Gilles
Comment 18 Dmitri Popov 2014-10-21 11:29:07 UTC
I see. I think your mockup is good. It's much better that the current wallet-based one, anyway.
Comment 19 caulier.gilles 2014-10-21 12:51:52 UTC
Git commit 065203d1701a8a62249e52a6ac666f1c6e2f61b6 by Gilles Caulier.
Committed on 21/10/2014 at 12:49.
Pushed by cgilles into branch 'master'.

Change icon-view group icons with Oxygen image-stack images.
Add new information in group icon tool tip to indicate how many items are grouped and if group is open or closed.
FIXED-IN: 4.5.0

M  +17   -1    app/items/overlays/groupindicatoroverlay.cpp
M  +2    -2    libs/widgets/itemview/itemviewimagedelegate.cpp

http://commits.kde.org/digikam/065203d1701a8a62249e52a6ac666f1c6e2f61b6