Contents of QHeaderView sections clipped with Breeze style. Popped up in Kexi first, where I put icons in header sections of table views (by returning a KDE icon for Qt::DecorationRole in implementation of QAbstractItemModel::headerData()). See upper part of the first attached screenshot. Also found it in the JuK music player (here, the text is clipped). See lower part of the first attached screenshot. Reproducing: just run JuK and look at the headers of the main list. I have not inspected JuK's code so I don't know if QHeaderView is used explicitly. If you want to try Kexi, you'd have to build it with my patch (let me know), the code using QHeaderView isn't packaged. Reproducible: Always Actual Results: Cropped content. Expected Results: Entire content is displayed.
Created attachment 89210 [details] Screenshot of the bug in Kexi and JuK
Kexi uses Qt4's QAbstractScrollArea, to be strict, and QHeaderView. Height of the row in Kexi is based on QFontMetrics::height() of the used font. It is 19 on the screenshot. Small height (or width) isn't something unusual in large data sheets of db or in spreadsheets. Attaching a test .ui file below that uses QTableWidget, which is based on the same technology. I set verticalHeaderDefaultSectionSize to 19 there. Expected fix would be to avoid adding so large margins.
Created attachment 89211 [details] .ui test that shows the bug in QTableWidget
(In reply to Jarosław Staniek from comment #2) > Kexi uses Qt4's QAbstractScrollArea, to be strict, and QHeaderView. > > Height of the row in Kexi is based on QFontMetrics::height() of the used > font. It is 19 on the screenshot. Small height (or width) isn't something > unusual in large data sheets of db or in spreadsheets. > That is likely what creates the issue. Breeze, per design, adds margins around the content. You are supposed to call QStyle::sizeForContents( CT_HeaderView, ...) to get the size of the header for a given contents size. Fixing it to anything smaller like this is bound to break on one style or the other ... This can probably be worked-around in breeze (by unclipping the text, that is, allow drawing on the margins) but the real fix would be really not to fix the size of the header line. Fixing sizes at the application level just brings inconsistencies from one app to the other, which is precisely what the style aims at preventing ...
I understand but in my optics the higher priority is to adhere to what's defined in file format. E.g. if a spreadsheet in given zoom level takes 19 physical pixels, we have to paint 19 pixels whatever toolkit or style is used. I am not sure why only breeze reproduces the issue. Think about the header as a part of document's content rather than the GUI itself. Like a table header in a wordprocessor: it should be able to even take 2 pixels if this is what the document says :)
--- a/kstyle/breezestyle.cpp +++ b/kstyle/breezestyle.cpp @@ -1475,7 +1475,8 @@ namespace Breeze if( !headerOption ) return option->rect; // check if arrow is necessary - QRect labelRect( insideMargin( option->rect, Metrics::Header_MarginWidth ) ); + // QRect labelRect( insideMargin( option->rect, Metrics::Header_MarginWidth ) ); + QRect labelRect( insideMargin( option->rect, Metrics::Header_MarginWidth, 0 ) ); if( headerOption->sortIndicator == QStyleOptionHeader::None ) return labelRect; labelRect.adjust( 0, 0, -Metrics::Header_ArrowSize-Metrics::Header_ItemSpacing, 0 ); Can you test ? If fixes I'll push
(In reply to Jarosław Staniek from comment #5) > I understand but in my optics the higher priority is to adhere to what's > defined in file format. E.g. if a spreadsheet in given zoom level takes 19 > physical pixels, we have to paint 19 pixels whatever toolkit or style is > used. I am not sure why only breeze reproduces the issue. > Because its the only style I know of that adds the margins and actually enforces respecting it.
Thanks, I'll try tonight. On 20 October 2014 15:25, Hugo Pereira Da Costa <hugo.pereira@free.fr> wrote: > Comment # 6 on bug 340150 from Hugo Pereira Da Costa > > --- a/kstyle/breezestyle.cpp > +++ b/kstyle/breezestyle.cpp > @@ -1475,7 +1475,8 @@ namespace Breeze > if( !headerOption ) return option->rect; > > // check if arrow is necessary > - QRect labelRect( insideMargin( option->rect, > Metrics::Header_MarginWidth ) ); > + // QRect labelRect( insideMargin( option->rect, > Metrics::Header_MarginWidth ) ); > + QRect labelRect( insideMargin( option->rect, > Metrics::Header_MarginWidth, 0 ) ); > if( headerOption->sortIndicator == QStyleOptionHeader::None ) > return > labelRect; > > labelRect.adjust( 0, 0, > -Metrics::Header_ArrowSize-Metrics::Header_ItemSpacing, 0 ); > > Can you test ? > If fixes I'll push > > ________________________________ > You are receiving this mail because: > > You reported the bug.
Git commit 70af858a6d1afe9899fb76fd64a83585618c3fb0 by Hugo Pereira Da Costa. Committed on 20/10/2014 at 13:23. Pushed by hpereiradacosta into branch 'master'. Do not clip away vertical margins for headers to accomodate custom widgets that set a two small vertical size for those. M +2 -1 kstyle/breezestyle.cpp http://commits.kde.org/breeze/70af858a6d1afe9899fb76fd64a83585618c3fb0
Git commit 5542c48d9c3b07559ee5c600a14a192518e5e4e0 by Hugo Pereira Da Costa. Committed on 20/10/2014 at 13:23. Pushed by hpereiradacosta into branch 'Plasma/5.1'. Do not clip away vertical margins for headers to accomodate custom widgets that set a two small vertical size for those. M +2 -1 kstyle/breezestyle.cpp http://commits.kde.org/breeze/5542c48d9c3b07559ee5c600a14a192518e5e4e0
Git commit 2100ca125c961d68e566b53bc63ec3885260b669 by Hugo Pereira Da Costa. Committed on 20/10/2014 at 22:09. Pushed by hpereiradacosta into branch 'master'. properly handle RTL for corner rects and tabbar Do not clip away vertical margins for headers to accomodate custom widgets that set a two small vertical size for those. Related: bug 340155 M +12 -25 kstyle/oxygenstyle.cpp http://commits.kde.org/oxygen/2100ca125c961d68e566b53bc63ec3885260b669
Git commit 17e1053bc03ace87502999776294d4be29b2b8f0 by Hugo Pereira Da Costa. Committed on 20/10/2014 at 22:09. Pushed by hpereiradacosta into branch 'Plasma/5.1'. properly handle RTL for corner rects and tabbar Do not clip away vertical margins for headers to accomodate custom widgets that set a two small vertical size for those. Related: bug 340155 M +12 -25 kstyle/oxygenstyle.cpp http://commits.kde.org/oxygen/17e1053bc03ace87502999776294d4be29b2b8f0
Looks much better, thanks Hugo! I'll let you know if there's another glitch.