Bug 340085 - Brush cursor border hard to see over specific color
Summary: Brush cursor border hard to see over specific color
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 362306 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-10-18 07:19 UTC by Tyson Tan
Modified: 2017-03-01 14:56 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Brush border over color #068B14 (right bottom of the canvas) (749.10 KB, image/png)
2014-10-18 07:22 UTC, Tyson Tan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tyson Tan 2014-10-18 07:19:02 UTC
The brush cursor's border, when moving over some color, becomes very hard to see. So far I've noticed a few of them:
#068B14
#0583BD
#0D84C2
Which seems to follow the pattern of #**8***

Reproducible: Always


Actual Results:  
The brush cursor's border, when moving over some color, becomes very hard to see.

Expected Results:  
The brush cursor's border can be easily seen over any color.
Comment 1 Tyson Tan 2014-10-18 07:22:39 UTC
Created attachment 89184 [details]
Brush border over color #068B14 (right bottom of the canvas)
Comment 2 Halla Rempt 2014-11-04 14:30:05 UTC
Confirmed... It's not so easy to fix, though :-(
Comment 3 Tyson Tan 2014-11-05 12:35:00 UTC
@Boud
How about displaying two adjacent outlines like concentric circles, with different parameters or algorithms?
Comment 4 Halla Rempt 2016-04-27 12:21:55 UTC
*** Bug 362306 has been marked as a duplicate of this bug. ***
Comment 5 1DrawingPerDay 2016-05-15 15:22:02 UTC
Maybe there should be an option to choose cursor color in Krita's settings?

The green cursor is tough on the eyes on certain backgrounds (e.g. a light grey)
Comment 6 wolthera 2016-05-16 10:07:33 UTC
Well, the thing is that the cursor is not supossed to be merely 'bright green', it instead shows a negative on the canvas, we don't know on whose systems it's showing up as bright green, so could you report a seperate bug with your system specs?

That's not the bug tyson was experiencing though.
Comment 7 Halla Rempt 2016-05-25 12:10:49 UTC
Git commit 7236d4457d5b345dacadc22936e00d1bfac507ae by Boudewijn Rempt.
Committed on 25/05/2016 at 12:10.
Pushed by rempt into branch 'master'.

Add note about gllogicop

Though I think that on AMD, it doesn't work even if it's defined,
so We still need to figure out another way to draw the cursor.
Related: bug 363124

M  +2    -0    libs/ui/opengl/kis_opengl_canvas2.cpp

http://commits.kde.org/krita/7236d4457d5b345dacadc22936e00d1bfac507ae
Comment 8 Halla Rempt 2016-08-17 08:26:04 UTC
I can now reproduce this issue now that I've got a "pro" nvidia card, a cheapo quadro.
Comment 9 Martin Schultz 2016-12-07 13:15:33 UTC
Happens for me in stable release and beta and nightly.

Weird thing is the first couple of times I used Krita it didn't happen and I've only been using 3.0+.

I have a Gigabyte GTX 780 Ti SC and I've reinstalled the latest drivers.

Does NOT happen in in 2.x. (which means I've been using the latest 2.x version these couple of weeks/months)
Comment 10 guill 2016-12-29 21:33:58 UTC
Happens to me in stable 3.1.1. When the brush is small, it is impossible to see on white background and constantly have to move my cursor in the corner of my monitor to find out where it is. I keep losing track of it, very unproductive. A simple option to override the negative color and force a chosen color would be an interesting workaround for systems having the issue. You would have to change it depending on what your background but it would be much less impractical than not seeing it at all.

Operating System:	Windows 10 Home, 64-bit
DirectX version:	12.0 
GPU processor:		GeForce GTX 1080
Driver version:		376.33
Comment 11 Martin Schultz 2017-01-20 19:04:58 UTC
Built a brand new computer and have some new info.

Before installing Nvidia graphics drivers (only running Intel Graphics on my second monitor) I got a solid black cursor which was even worse as it was literally impossible to see on a black background.

Windows got my main monitor up and running. NOTE: I'm still without the real drivers for my GPU. Now the cursor in Krita is working as I should! I'm full of joy!

After I installed the Nvidia drivers it went back to being the solid light green color. NOTHING else could have been conflicting with it as the ONLY things I installed while testing Krita was standard Windows updates and the Nvidia graphics drivers.

So is this something Nvidia should fix? Well that depends how you look at it. But assuming that Nvidia will fix it will most likely mean that we will never ever see a fix.

Hardware:
OS: Windows 10 Home 64 bit 
GPU: Palix GTX 1080 Gamerock Premium Edition (stock clock)
Driver version: 376.33 (12/14-2016)
DirectX version: 12
OpenGL version: 4.4 (Only thing it doesn't support in 4.5 is the shading language which obviously is rather important. Both ARB 2015 and 2016 is fully supported)
CPU: Intel Core i7 7700K (stock clock)
RAM: 2x16GB (32GB) Corsair Vengeance LPX @ 3000 MHz (Tested clock)
Motherboard: ASUS ROG Strix Z270G
Storage: Crucial MX300 1TB M.2 SSD (SATA)
PSU: Seasonic Prime 650W (not in hybrid mode)
Comment 12 Halla Rempt 2017-01-21 12:40:47 UTC
"So is this something Nvidia should fix? Well that depends how you look at it. But assuming that Nvidia will fix it will most likely mean that we will never ever see a fix."

Yes, that's correct. Doesn't closed source software development suck? Isn't open source nice? You can not only discuss issues openly and directly with the developers, you could even try to fix issues yourself. 

We've worked around hundreds of issues with broken hardware drivers, broken window managers and so on, and I'm hoping someone will step up and code a workaround for this issue as well -- nobody has done that yet, though. And I haven't got time to work on this, it's just one of 319 open bugs.

And this bug isn't my highest priority bug, because even though I get the green outline on my quadro, I never have the cursor disappear on white background, not even if the brush is only one pixel. Besides, there are a ton of cursor options that people can use as workarounds.
Comment 13 Martin Schultz 2017-01-21 12:48:12 UTC
(In reply to Boudewijn Rempt from comment #12)
I'm sorry if it came out as a rude comment. I know there's many other issues to be looked at and some far more important. I was just speaking my mind because I've read other places that we should wait for a fix from Nvidia.
Comment 14 wolthera 2017-01-21 16:06:06 UTC
I think it's more an expression of frustration really. We'd like to be able to fix bugs ourselves too, but there's at the least 10 bugs that we cannot fix because of hardware drivers, and that is very frustrating :(
Comment 15 Tyson Tan 2017-01-21 16:44:35 UTC
As the original reporter, I don't "feel" this bug anymore. It was such a minor glitch. Certainly, it would be nice to see it fixed. But if too much work is needed, I agree with Boud and wolthera that we should spend our limited resources on more important problems.
Comment 16 guill 2017-01-26 18:51:58 UTC
(In reply to Boudewijn Rempt from comment #12)
>Besides, there are a
>ton of cursor options that people can use as workarounds.

What options, if you don't mind sharing?


(In reply to Tyson Tan from comment #15)
> As the original reporter, I don't "feel" this bug anymore. It was such a
> minor glitch. Certainly, it would be nice to see it fixed. But if too much
> work is needed, I agree with Boud and wolthera that we should spend our
> limited resources on more important problems.

Now some people seem to feel that the issue is not much of a deal but without a workaround right now this makes the software unusable for me. If you use a brush smaller than 2px and have a 26" 1440p monitor, good luck finding where the cursor is on a light background. I can't even imagine what it's like for people with some degree of colour blindness. Anyway, I'm not complaining or anything, I understand this is open-source software, but just wanted to weigh in regarding the felt importance thereof.
Comment 17 Martin Schultz 2017-01-26 18:55:48 UTC
(In reply to guill from comment #16)
> What options, if you don't mind sharing?

Settings > Configure Krita > General (top tab on the left) > Cursor > Cursor Shape

(My Krita is in danish so I had to translate it)
Comment 18 guill 2017-01-29 23:38:25 UTC
(In reply to Martin Schultz from comment #17)
> (In reply to guill from comment #16)
> > What options, if you don't mind sharing?
> 
> Settings > Configure Krita > General (top tab on the left) > Cursor > Cursor
> Shape
> 
> (My Krita is in danish so I had to translate it)

This works wonders! It was so much in my face it's kind of shameful I didn't see it. Thanks!
Comment 19 Halla Rempt 2017-03-01 14:56:46 UTC
Fixed in

commit 331b4501488aaa02afbc964272164a34b86f5ef3
Author: Joseph-Eugene Winzer <m999@openmailbox.org>
Date:   Fri Feb 10 15:50:02 2017 +0100

    Fix glLogicOp by using QOpenGLFunctions_3_0 instead of GLES2 + WGL