Bug 339933 - ICONVIEW : Incorrect Image Aspect Ratio shown.
Summary: ICONVIEW : Incorrect Image Aspect Ratio shown.
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Thumbs-IconView (show other bugs)
Version: 4.4.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-13 14:22 UTC by Paul
Modified: 2017-07-28 15:15 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.9.0
Sentry Crash Report:


Attachments
Screen-shot showing incorrect aspect ratios. (92.02 KB, image/png)
2014-10-13 14:22 UTC, Paul
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul 2014-10-13 14:22:32 UTC
Created attachment 89116 [details]
Screen-shot showing incorrect aspect ratios.

The aspect ratio information shown (Album List - Icon View) appears to always be 3:2 irrespective of the image size.

See attached screen-shot showing images with (actual) aspect ratios of 4:3, 3:2, and 1:1 - digiKam displays all three as 3:2

(Not shown, but the tool-tip also has the incorrect value.)
Comment 1 caulier.gilles 2014-10-13 15:30:48 UTC
Can you share the images to reproduce in my computer ?

Gilles Caulier
Comment 2 Paul 2014-10-13 16:00:17 UTC
https://dl.dropboxusercontent.com/u/221041460/dk-aspect/20140707T173628-0-4%3A3.jpg
https://dl.dropboxusercontent.com/u/221041460/dk-aspect/20140707T173628-0-1%3A1.jpg
https://dl.dropboxusercontent.com/u/221041460/dk-aspect/20140707T173628-0-3%3A2.jpg

https://dl.dropboxusercontent.com/u/221041460/dk-aspect/20140625T155326-0-4%3A3.jpg

The first three have been edited in GIMP, although I'm sure this is not relevant. The fourth is 'as was' imported from camera into digiKam.  I've subsequently checked many images, all have the aspect ratio shown as 3:2, irrespective of the actual image size...
Comment 3 caulier.gilles 2015-03-25 08:19:54 UTC
Maik,

You have patched ratio values computation with more recent release as i remember. Right ?

So, i think this file is already fixed at least with 4.8.0...

Gilles Caulier
Comment 4 Maik Qualmann 2015-03-25 18:48:47 UTC
Yes, this bug can be closed is fixed in 4.9.0.

Maik
Comment 5 Paul 2015-03-25 18:51:56 UTC
Using version 4.8.0

There is still a problem when the aspect ratio is (or is close to) 1:1
For example, I have an image 2342 x 2342 whose aspect ratio is shown as 5:4(1.25)

To reproduce, simply crop any image to 1:1 - the aspect ratio will then be incorrectly shown.

Other than that, it appears to be working fine :)
Comment 6 Paul 2015-03-25 18:53:22 UTC
(In reply to Maik Qualmann from comment #4)
> Yes, this bug can be closed is fixed in 4.9.0.
> 
> Maik

Does that fix the 1:1 issue?
Comment 7 caulier.gilles 2015-03-25 18:56:12 UTC
Paul, 

I think yes. Look file #342931 closed by Maik with next 4.9.0 release.

Gilles
Comment 8 Maik Qualmann 2015-03-25 19:01:50 UTC
> Does that fix the 1:1 issue?

No, 1:1 is now displayed as 11:10...to be continued ...

Maik
Comment 9 Paul 2015-03-25 19:07:59 UTC
(In reply to Maik Qualmann from comment #8)
> > Does that fix the 1:1 issue?
> 
> No, 1:1 is now displayed as 11:10...to be continued ...
> 
> Maik

OK... Thanks!
Comment 10 Maik Qualmann 2015-03-25 22:35:48 UTC
Git commit 400f0df2ac33718cdf50bf002516da0a180e4a10 by Maik Qualmann.
Committed on 25/03/2015 at 22:34.
Pushed by mqualmann into branch 'master'.

aspect ratio 1:1 is now displayed correctly
FIXED-IN: 4.9.0

M  +0    -12   libs/imageproperties/imagepropertiestab.cpp

http://commits.kde.org/digikam/400f0df2ac33718cdf50bf002516da0a180e4a10
Comment 11 caulier.gilles 2015-03-25 22:45:23 UTC
Git commit f1279311edb931a5da7828c064ab381019ce6f43 by Gilles Caulier.
Committed on 25/03/2015 at 06:35.
Pushed by cgilles into branch 'frameworks'.

backport commit #400f0df2ac33718cdf50bf002516da0a180e4a10 from git/master to frameworks branch

M  +1    -13   libs/imageproperties/imagepropertiestab.cpp

http://commits.kde.org/digikam/f1279311edb931a5da7828c064ab381019ce6f43