Bug 339655 - Display assigned VAT account in list view
Summary: Display assigned VAT account in list view
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: 4.6.6
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-04 09:45 UTC by Ralf Habacker
Modified: 2014-10-22 05:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.7.1


Attachments
Display assigned vat account in VAT column of list view (1.16 KB, patch)
2014-10-04 09:46 UTC, Ralf Habacker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2014-10-04 09:45:19 UTC
Accounts/Categories having assigned VAT accounts and VAT accounts could not be identified in the list view. Both are displaying a check mark in the list view. 



Reproducible: Always

Steps to Reproduce:
1. open kmymoney
2. create new file using the skr3 template
3. set VAT to account 1575 to 19%
4. assign this vat account to account 4940
5. show categories


Actual Results:  
account 4940 display a checkmark in the VAT column

Expected Results:  
account should display the assigned VAT account

The appended patch fixes this issue by showing the assigned VAT account in the VAT column.
Comment 1 Ralf Habacker 2014-10-04 09:46:12 UTC
Created attachment 88949 [details]
Display assigned vat account in VAT column of list view
Comment 2 Thomas Baumgart 2014-10-05 07:25:11 UTC
Git commit f803f3f9ee6cd82b1d0fab5fe0e69ab368ac0ebe by Thomas Baumgart.
Committed on 05/10/2014 at 07:22.
Pushed by tbaumgart into branch 'master'.

Display assigned VAT account in list view

The category view contains a column called VAT which showed a check mark
when the category in question has a VAT category assigned. Now the name
of that VAT category is shown instead of the check mark.

M  +4    -1    kmymoney/models/accountsmodel.cpp

http://commits.kde.org/kmymoney/f803f3f9ee6cd82b1d0fab5fe0e69ab368ac0ebe
Comment 3 Cristian Oneț 2014-10-22 05:09:07 UTC
Git commit 233bcf403226cf669cdae22cff211ef29a22a5a9 by Cristian Oneț, on behalf of Thomas Baumgart.
Committed on 05/10/2014 at 07:22.
Pushed by conet into branch '4.7'.

Display assigned VAT account in list view

The category view contains a column called VAT which showed a check mark
when the category in question has a VAT category assigned. Now the name
of that VAT category is shown instead of the check mark.
(cherry picked from commit f803f3f9ee6cd82b1d0fab5fe0e69ab368ac0ebe)

M  +4    -1    kmymoney/models/accountsmodel.cpp

http://commits.kde.org/kmymoney/233bcf403226cf669cdae22cff211ef29a22a5a9
Comment 4 Cristian Oneț 2014-10-22 05:11:43 UTC
I've pushed this into 4.7 since also since the fix for BUG 339693 is in the same area and picking only the commit for BUG 339693 would cause a conflict, because it did not contain this patch. So even if this is a feature it was picked in 4.7.