Bug 339530 - kget-4.14.1/transfer-plugins/bittorrent/bttransfer.cpp:314: bad code ?
Summary: kget-4.14.1/transfer-plugins/bittorrent/bttransfer.cpp:314: bad code ?
Status: CONFIRMED
Alias: None
Product: kget
Classification: Applications
Component: torrent (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KGet authors
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-30 15:50 UTC by dcb314
Modified: 2018-11-12 16:25 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description dcb314 2014-09-30 15:50:23 UTC 
kget-4.14.1/transfer-plugins/bittorrent/bttransfer.cpp:314:47: warning: unsequenced modification and access to 'm_downloadedSize' [-Wunsequenced]

    if (m_downloadedSize != (m_downloadedSize = torrent->getStats().bytes_downloaded))

Suggest code rework.


Reproducible: Always
Comment 1 Andrew Crouthamel 2018-11-12 02:49:50 UTC 
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 2 dcb314 2018-11-12 08:14:50 UTC 
After all these years, the problem still exists. In function BTTransfer::updateTorrent
Comment 3 Andrew Crouthamel 2018-11-12 16:25:56 UTC 
Thanks for the update!