Bug 339513 - kget should remember columns' widths on reopen
Summary: kget should remember columns' widths on reopen
Status: CONFIRMED
Alias: None
Product: kget
Classification: Applications
Component: UI (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: KGet authors
URL:
Keywords:
: 483787 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-09-29 16:19 UTC by Coacher
Modified: 2024-03-16 21:30 UTC (History)
10 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Bug fix patch (3.45 KB, patch)
2014-12-23 18:27 UTC, stream9
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Coacher 2014-09-29 16:19:37 UTC
With kget from KDE SC 4.14.1 I have the following problem. If I manually adjust width of columns in UI (Name, Status, Size, etc.), their widths are reset on reopen.
It should not be this way. Please fix.

Reproducible: Always

Steps to Reproduce:
1. Adjust columns' width in kget
2. Reopen kget

Actual Results:  
Columns' widths are reset to default.

Expected Results:  
Columns' widths are the same as adjusted by user.
Comment 1 Coacher 2014-10-19 23:54:42 UTC
Still reproducible in 4.14.2
Comment 2 stream9 2014-12-23 18:27:33 UTC
Created attachment 90100 [details]
Bug fix patch

working in 4.14.3
Comment 3 Luca Giambonini 2015-01-25 19:26:36 UTC
I confirm the issue on 4.14.3 (Chakra Linux)
I added the patch to kget in our repository an now the issue is fixed. Thank you!
Comment 4 Linux User #330250 2015-05-17 09:41:36 UTC
Thanks for the patch! Worked very well with kget-4.14.3 on Gentoo Linux.
Comment 5 Patrick Silva 2018-02-28 19:24:33 UTC
kget 2.95 has the same bug on Arch Linux.
Comment 6 Patrick Silva 2018-02-28 19:26:11 UTC
sorry, I meant kget 17.12.2.
Comment 7 Linux User #330250 2018-10-13 16:29:04 UTC
Why is this fix not yet merged upstream in the kget sources? Who reads–or rather doesn't read–this bug tracker?

The patch still worked for me on Gentoo Linux amd64, kde-apps/kget-18.04.3.

PLEASE merge this patch from stream9 into the upstream sources! Thanks.
Comment 8 Wolfgang Bauer 2019-01-05 23:40:24 UTC
(In reply to Linux User #330250 from comment #7)
> Why is this fix not yet merged upstream in the kget sources? Who reads–or
> rather doesn't read–this bug tracker?

I do read it, but I didn't get notified of new comments in this bug report.
But it actually is something that bothered me as well since years anyway.

But, the proposed fix is not completely working.
It causes a new problem, because if you hide a column via the list header's right-click context menu, this is remembered as well now.
Good thing in principle of course, but the initial state of the menu is wrong then, i.e. it shows up as activated on next start although it is hidden (the state is just inverted in that case).

I do have a fix ready for that as well, but that shows that I probably should think more about whether this is actually the right way to fix it or there's a better one.

And I haven't found the time to do that yet, sorry.
It is on my TODO list, but I also preferred to fix regressions in the KF5 port for now.
Comment 9 Wolfgang Bauer 2019-01-05 23:50:57 UTC
And speaking generally, patches should better be proposed on phabricator.kde.org (or reviewboard.kde.org in the past) to have them reviewed properly.

Adding them to some bug report just tends to them getting lost, forgotten, or overlooked, especially if new people take over...
Comment 10 Nathan DeGruchy 2019-10-09 16:44:20 UTC
Confirming that this is still an issue in 19.8.1 on openSuSE Tumbleweed.
Comment 11 Fritjof Larsson 2020-07-23 23:11:58 UTC
Still reproducible with 20.04.3 on Tumbleweed.
Comment 12 Patrick Silva 2024-03-16 21:30:12 UTC
*** Bug 483787 has been marked as a duplicate of this bug. ***