Bug 339456 - Thumbnailers in kio-extras needs porting to KF5
Summary: Thumbnailers in kio-extras needs porting to KF5
Status: RESOLVED FIXED
Alias: None
Product: kio-extras
Classification: Frameworks and Libraries
Component: default (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Development Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-27 13:21 UTC by Bhushan Shah
Modified: 2017-05-07 14:06 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bhushan Shah 2014-09-27 13:21:38 UTC
I tried to port it but somehow it is not working, it will be very good if people with more knowledge in this area can take a look at it.

Reproducible: Always
Comment 1 Bhushan Shah 2014-09-27 13:23:41 UTC
It will be very good to have at least text and video files thumbnailers working..
Comment 2 Christoph Feck 2014-09-27 13:30:38 UTC
The ffmpeg thumbnailer was already ported by Hrvoje, it is not in kio-extras, though.
Comment 3 Maarten De Meyer 2014-09-28 15:46:08 UTC
Git commit 72d25f79050f8cf249b0a640a2be8764c59eca91 by Maarten De Meyer.
Committed on 28/09/2014 at 15:35.
Pushed by demeyer into branch 'master'.

Port comicbook thumbnailer to KF5

Mostly standard porting stuff.
Still need to change qdebug calls to qCDebug.
REVIEW: 120382

M  +1    -0    CMakeLists.txt
M  +13   -9    thumbnail/CMakeLists.txt
M  +19   -22   thumbnail/comiccreator.cpp

http://commits.kde.org/kio-extras/72d25f79050f8cf249b0a640a2be8764c59eca91
Comment 4 Maarten De Meyer 2014-09-29 19:42:56 UTC
Git commit 7cadf8888ec1b02e30512a44c1bae76202f30f96 by Maarten De Meyer.
Committed on 28/09/2014 at 22:32.
Pushed by demeyer into branch 'master'.

Port textcreator thumbnailer

Thumbcreator needs to be a QGuiApplication because we use pixmaps.
REVIEW: 120408

M  +14   -11   thumbnail/CMakeLists.txt
M  +7    -7    thumbnail/textcreator.cpp
M  +1    -1    thumbnail/thumbnail.cpp

http://commits.kde.org/kio-extras/7cadf8888ec1b02e30512a44c1bae76202f30f96
Comment 5 Elvis Angelaccio 2017-05-07 14:06:10 UTC
This has been fixed for a while.