Bug 339366 - Please install the supplied AppData file
Summary: Please install the supplied AppData file
Status: RESOLVED FIXED
Alias: None
Product: kajongg
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Wolfgang Rohdewald
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-24 19:18 UTC by Richard Hughes
Modified: 2015-04-16 16:44 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Hughes 2014-09-24 19:18:02 UTC
Please consider improving and installing this AppData file we wrote: https://raw.githubusercontent.com/hughsie/fedora-appstream/master/appdata-extra/desktop/kajongg.appdata.xml

This is used in GNOME and KDE software installers to add the application description and some screenshots. We'd love to showcase more applications, but without the extra data file we can't. The AppData file needs to be installed to /usr/share/appdata/ on Linux and the basename needs to match the .desktop basename. It would also be great if you could integrate the file with your translation system (e.g. intltool) to make the descriptions translated.

See http://people.freedesktop.org/~hughsient/appdata/ for more details; thanks!

Richard


Reproducible: Always
Comment 1 Wolfgang Rohdewald 2014-09-24 19:48:07 UTC
The description is not quite accurate: against up to four players means there is a total of five players.

Also "up to three" suggests it can be played by 1 or 2 players alone. But the number of players is always exactly four.

Maybe 

Mah Jongg is a game for four players. Every player can either be a real person or a computer player.
(In demo mode, you have four computer players)

English is not my native language, so if you could fix this, I will gladly integrate this file following this: http://blog.tenstral.net/2014/05/translated-appstream-metadata-for-kde.html

According to that description your appdata cannot be translated by KDE translators because its metadata version is older than 0.6. Please upgrade.
Comment 2 Richard Hughes 2014-09-25 10:23:05 UTC
I've upgraded the file to 0.6 version. This means it can't be used in older distros like Fedora 20, but like you say, it can be translated. Thanks!
Comment 3 Christoph Feck 2014-10-25 14:43:21 UTC
Does comment #2 imply that this ticked can be marked as resolved? If not, what information is needed for the next step?
Comment 4 Wolfgang Rohdewald 2014-10-26 11:12:32 UTC
IMHO it is not resolved because the description is not quite correct as I wrote in comment #1. That is why I did not yet integrate the file.
Comment 5 Rex Dieter 2015-04-16 16:44:17 UTC
Looks like something got committed in the meantime:

https://projects.kde.org/projects/kde/kdegames/kajongg/repository/revisions/master/changes/kajongg.appdata.xml

which was only included in the latest 15.04.0 (stable) release.

If there's any improvement(s) to be made, just commit it there (imho).