Bug 339207 - Applying various panel settings is broken
Summary: Applying various panel settings is broken
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (other bugs)
Version First Reported In: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-19 11:05 UTC by Martin Klapetek
Modified: 2014-10-10 15:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Panel is off its own rules (76.67 KB, image/png)
2014-09-26 22:11 UTC, Martin Klapetek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Klapetek 2014-09-19 11:05:09 UTC
All can be seen in https://www.dropbox.com/s/elszb5vohqujx07/panel_settings.mkv?dl=0 -- alternatively there's a download button for higher res.

1) Maximizing centered panel grows the panel only to the right, not both sides, additionally the panel can get switched to the other screen

2) Switching maximized panel to Center puts it on the other screen

3) Resizeing centered panel hides part of the panel contents, appears back when panel settings is closed

4) Moving maximized panel from one screen (after 2 happened) does not keep it maximized, it's even smaller
Comment 1 Marco Martin 2014-09-26 16:26:44 UTC
are those still relevant? can't reproduce most of them (if they are, they should be individual issues)

4) is intended, because panel geometries are independent by screen (and resolution) for several reasons
Comment 2 Martin Klapetek 2014-09-26 22:07:07 UTC
So in with the recent code

1) can still be reproduced
2) can still be reproduced (plus the panel is not maximized on the other screen either)
3) can still sometimes be reproduced

Plus one new issue happens for which I'll upload a screenshot.

As for separate issues - I've recorded them all in one vide and I /think/ these are all related, so I've filed it under one single bug.
Comment 3 Martin Klapetek 2014-09-26 22:11:16 UTC
Created attachment 88854 [details]
Panel is off its own rules

In this screenshot it can be seen that the panel does not match either one of the ruler's position things.

Steps to reproduce were - make the panel smaller and then make it center aligned then make it smaller again and while doing so, the panel would sometimes just jump to the other screen completely.
Comment 4 Marco Martin 2014-10-01 15:52:22 UTC
Git commit 0d6f120820ed6df0debc584e2f21ee0861549b95 by Marco Martin.
Committed on 01/10/2014 at 15:49.
Pushed by mart into branch 'Plasma/5.1'.

reposition panel on resize

needed for center and right alignments
now 90% of the times the behavior of the panel controller is correct.
but problems still happen
Related: bug 339202

M  +2    -0    shell/panelview.cpp

http://commits.kde.org/plasma-workspace/0d6f120820ed6df0debc584e2f21ee0861549b95
Comment 5 Marco Martin 2014-10-01 15:52:23 UTC
Git commit d6512ab7e7a466d349439994bee3a0a6c9f39c44 by Marco Martin.
Committed on 01/10/2014 at 15:49.
Pushed by mart into branch 'master'.

reposition panel on resize

needed for center and right alignments
now 90% of the times the behavior of the panel controller is correct.
but problems still happen
Related: bug 339202

M  +2    -0    shell/panelview.cpp

http://commits.kde.org/plasma-workspace/d6512ab7e7a466d349439994bee3a0a6c9f39c44
Comment 6 Marco Martin 2014-10-09 14:56:24 UTC
Git commit 00df10848ce24b197e4d471ecc0821a15abd66b7 by Marco Martin.
Committed on 09/10/2014 at 14:52.
Pushed by mart into branch 'Plasma/5.1'.

don't bind the panel size

it causes the root item size to flicker when reiszing the panel
Related: bug 337382

M  +1    -2    desktoppackage/contents/views/Panel.qml

http://commits.kde.org/plasma-desktop/00df10848ce24b197e4d471ecc0821a15abd66b7
Comment 7 Marco Martin 2014-10-10 11:24:16 UTC
closing now after last batch of commits adress those issues.
if other probolems persist, open one bug per separate issue
Comment 8 Martin Klapetek 2014-10-10 15:16:22 UTC
Awesome, thanks, it's much better now. Some problems still persist but I'll file them separately (bug 339846 already filed)